Final 1.0.12 release #693
Open
Final 1.0.12 release #693
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkienzle
reviewed
Dec 17, 2025
| * Include the 2-Yukawa structure factor model | ||
| * Add Ruff pre-commit hooks for developers | ||
| * Figures are cached between builds for CI speed up | ||
| * Plugin model location docs updated |
Contributor
There was a problem hiding this comment.
Missing: * Include the truncated octahedran model.
This doc is for user-facing changes. I wouldn't mention developer changes (pre-commit hook and figure caching).
Collaborator
Author
There was a problem hiding this comment.
The truncated octahedran model wasn't included in v1.0.12.
|
|
||
| * Integration of Ruff linting into CI | ||
| * Code cleanup to fix linting errors | ||
| * Fix map() bug in "sasfit_compare" |
Contributor
There was a problem hiding this comment.
In this case there are no user-facing changes. Maybe * Maintenance release. No significant changes.
Collaborator
Author
There was a problem hiding this comment.
I'd argue * Fix map() bug in "sasfit_compare" is a user-facing change.
Contributor
There was a problem hiding this comment.
It is in the "explore" directory, so it is not part of the public code base.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the final HEAD for the release branch. The only differences are release notes.