Handle properties with no accessors#548
Open
Dredsen wants to merge 5 commits intoSamboyCoding:developmentfrom
Open
Handle properties with no accessors#548Dredsen wants to merge 5 commits intoSamboyCoding:developmentfrom
Dredsen wants to merge 5 commits intoSamboyCoding:developmentfrom
Conversation
… both been stripped completely. Il2CppPropertyDefinition.PropertyType / RawPropertyType derived their result solely from the accessor signatures and dereferenced the setter with null-forgiving operators, NREing when both were null. Reproduced on Relic Arena (Unity 6000.3.14f1) where ZstdSharp.Unsafe.Methods contains a bad property, crashing CopyPropertiesInType and failing afterwards. - Il2CppPropertyDefinition: PropertyType, RawPropertyType, and IsStatic now return null / false instead of NRE when both accessors are missing. - AsmResolverAssemblyPopulator.CopyPropertiesInType: skip properties with no accessors - AsmResolverAssemblyPopulator.PopulateCustomAttributes: skip properties that were skipped above
ds5678
suggested changes
May 10, 2026
Co-authored-by: Jeremy Pritts <49847914+ds5678@users.noreply.github.com>
Co-authored-by: Jeremy Pritts <49847914+ds5678@users.noreply.github.com>
Co-authored-by: Jeremy Pritts <49847914+ds5678@users.noreply.github.com>
Co-authored-by: Jeremy Pritts <49847914+ds5678@users.noreply.github.com>
ds5678
approved these changes
May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some IL2CPP metadata contains properties whose getter and setter have both been stripped completely.
Il2CppPropertyDefinition.PropertyType / RawPropertyType derived their result solely from the accessor signatures and dereferenced the setter with null-forgiving operators, NREing when both were null.
Reproduced on Relic Arena (Unity 6000.3.14f1) where ZstdSharp.Unsafe.Methods contains a bad property, crashing CopyPropertiesInType and failing afterwards.