Skip to content

Improve performance of converting contexts to AsmResolver types #545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ds5678 wants to merge 1 commit into
base: development
Choose a base branch
from
+3 −3
Open

Improve performance of converting contexts to AsmResolver types #545

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Cpp2IL.Core/Utils/AsmResolver/ContextToMethodDescriptor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ public static IMethodDescriptor ToMethodDescriptor(this ConcreteGenericMethodAna
}
else
{
var typeSignatures = methodGenericParameters.Select(p => p.ToTypeSignature(parentModule)).ToArray();
var typeSignatures = methodGenericParameters.Select(p => p.ToTypeSignature(parentModule));
return parentModule.DefaultImporter.ImportMethod(memberReference.MakeGenericInstanceMethod(typeSignatures));
}
}
Expand Down
4 changes: 2 additions & 2 deletions Cpp2IL.Core/Utils/AsmResolver/ContextToTypeSignature.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ private static TypeDefinition GetTypeDefinition(this TypeAnalysisContext context
public static TypeSignature ToTypeSignature(this TypeAnalysisContext context, ModuleDefinition parentModule) => context switch
{
ReferencedTypeAnalysisContext referencedTypeAnalysisContext => referencedTypeAnalysisContext.ToTypeSignature(parentModule),
_ => parentModule.DefaultImporter.ImportType(context.GetTypeDefinition()).ToTypeSignature(parentModule.RuntimeContext)
_ => parentModule.DefaultImporter.ImportType(context.GetTypeDefinition()).ToTypeSignature(context.IsValueType)
};

public static TypeSignature ToTypeSignature(this ReferencedTypeAnalysisContext context, ModuleDefinition parentModule) => context switch
Expand All @@ -32,7 +32,7 @@ private static TypeDefinition GetTypeDefinition(this TypeAnalysisContext context
public static GenericInstanceTypeSignature ToTypeSignature(this GenericInstanceTypeAnalysisContext context, ModuleDefinition parentModule)
{
var genericType = context.GenericType.ToTypeSignature(parentModule).ToTypeDefOrRef();
var genericArguments = context.GenericArguments.Select(a => a.ToTypeSignature(parentModule)).ToArray();
var genericArguments = context.GenericArguments.Select(a => a.ToTypeSignature(parentModule));

return new GenericInstanceTypeSignature(genericType, context.IsValueType, genericArguments);
}
Expand Down
Loading