Resolve relative location redirects during handshake #111
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the server returned a relative location during the NTLM handshake, httpreq/httpntlm previously replaced the full request URL with the relative path which caused the protocol (https) to be lost and resulted in a fatal ERR_INVALID_PROTOCOL error which could not be caught and would cause node to crash.
Example:
GET https://domain.com > 302 Redirect to http://domain.com
Node will crash and throw:
TypeError [ERR_INVALID_PROTOCOL]: Protocol "http:" not supported. Expected "https:"This change resolves redirect locations against the current request URL using the WHATWG URL resolver and sets options.url to the absolute href before retrying the NTLM flow. This preserves scheme/host/port and prevents protocol mismatch errors.
Added TypeScript type definitions for library.