Skip to content

Conversation

@dtracers
Copy link
Member

@dtracers dtracers commented Dec 3, 2019

Fixes #64

@todo
Copy link

todo bot commented Dec 3, 2019

?

// TODO ?
scene.traverse( child => {
if ( (<Mesh> child).isMesh ) {
(<MeshStandardMaterial> (<Mesh> child).material).envMap = envMap
}
})


This comment was generated by todo based on a TODO comment in b5d8311 in #72. cc @ipiv.

@Sciguymjm Sciguymjm requested a review from Abbondanzo December 3, 2019 18:24
Copy link
Member

@Abbondanzo Abbondanzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of quick comments and the file conflicts will also have to get resolved at some point

storageMemoize(async () => {
const { default: hdr } = await import(
// @ts-ignore
/* webpackChunkName: "Environment" */ "../../assets/models/textures/Environment/Environment.hdr"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Has this made it into SharedAssets yet?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, I haven't finished final render yet, current environment texture is a testrender I made.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is okay to put the test render in. It is honestly high quality enough for temporary use.

@Abbondanzo is there a way to flag the render under beta?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there a way to flag the render under beta?

Not entirely, but we can flag the version number in package.json as 0.7.0b or something of that nature. Publishing only happens once we cut releases in this repo

@lgtm-com
Copy link

lgtm-com bot commented Dec 4, 2019

This pull request introduces 1 alert when merging f77aea6 into d67de56 - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add skybox

4 participants