@W-22210602 cip analytics VS extension#404
Conversation
* @W-22210602: Adding CIP analytics to a new menu * @W-22210602: Adding Analytics report support in VS Code extension * @W-22210602: Adding Analytics report support in VS Code extension * fixing the result exports in csv and json * @W-22210602: Adding Analytics report support in VS Code extension * @W-22210602: Adding Analytics report support in VS Code extension * @W-22210602: Adding Analytics report support in VS Code extension * @W-22210602: Adding Analytics report support in VS Code extension * cip analytics report ux refinements --------- Co-authored-by: CharithaT07 <charitha.tadakanti777@gmail.com>
…ytics-VS-extension
…ytics-VS-extension
clavery
left a comment
There was a problem hiding this comment.
Looks good so far. Few initial notes:
This item I added recently to support our safety mode and analytics. Should be a simple mechanical fix.
- Doesn't use registerSafeCommand (safety.ts) — none of the 11 commands are gated.
api-browser/index.ts, sandbox-tree/, webdav-tree/, code-sync/ all route through registerSafeCommand. CIP uses vscode.commands.registerCommand directly (src/cip-analytics/index.ts:74-183). Most CIP commands are read-only so safety policy probably wouldn't block them, but bypassing the wrapper also means no
markFeatureUsed() telemetry fires for any CIP command. That's the bigger miss — the analytics feature itself is invisible to your usage analytics.
This item is a build consistency issue:
Styles shipped as 3,495-line raw CSS in src/cip-analytics/cip-styles.css with a special-case .vscodeignore exception (!src/cip-analytics/*.css).
The webview JS goes through esbuild → dist/webview-ui/, but the stylesheet is loaded straight from src/. That's an inconsistency — you reach back into src/ from a packaged extension. Nothing is broken (the .vscodeignore exception keeps it shipped), but it would be cleaner to either:
- Have esbuild copy/bundle it into dist/webview-ui/cip-styles.css (matches the JS), or
- Use the loader: {'.css': 'text'} rule already in webviewBuildOptions and import './cip-styles.css' from each entry — the rule is even configured already, but no one imports the CSS file. Right now it's dead-config.
Documentation — README/CHANGELOG entry, plus a new "VS Code IDE Integration" section in the existing analytics-reports-cip-ccac.md guide.
I'll have some UX/UI notes later
…ages These two pages were falling back to the site-wide default meta description. Add concise page-specific descriptions and a doc-only changeset.
#450) - qs: 6.14.1 → 6.15.2 (fixes CWE-770 resource allocation without limits) - picomatch: 2.3.1 → 2.3.2, 4.0.3 → 4.0.4 (fixes ReDoS vulnerability)
Summary
Polishes the CIP Analytics surface in the VS Code extension:
src/cip-analytics/types.ts) —replaced the generic folder icon with a distinct codicon per
category (
graph-line,package,account,search,tag,credit-card,globe,gear), humanized report slugs(
customer-registration-trends→Customer Registration Trends), and moved the SDK report description into theright-hand description slot in place of the trailing emoji.
.vscode/settings.json) — lightenedworkspace
list.descriptionForeground/list.deemphasizedForegroundto#9a9a9aso report subtextrecedes from the title.
src/cip-analytics/cip-styles.css) —switched the
B2C-DX ANALYTICSeyebrow on Query Builder andEntity Browser from
--vscode-descriptionForegroundto--cip-accent, picking up the theme's link/blue token.Testing
tsc --noEmitpasses forpackages/b2c-vs-extension.report rows show humanized titles + descriptions.
the theme accent (verified in light + dark themes).
Dependencies
rationale/discussion is included and
3pl-approvedis set by amaintainer
pnpm test)pnpm run format)