Skip to content

@W-22210602 cip analytics VS extension#404

Open
charithaT07 wants to merge 23 commits into
mainfrom
W-22210602-CIP-Analytics-VS-extension
Open

@W-22210602 cip analytics VS extension#404
charithaT07 wants to merge 23 commits into
mainfrom
W-22210602-CIP-Analytics-VS-extension

Conversation

@charithaT07
Copy link
Copy Markdown
Collaborator

Summary

Polishes the CIP Analytics surface in the VS Code extension:

  • Curated Reports tree (src/cip-analytics/types.ts) —
    replaced the generic folder icon with a distinct codicon per
    category (graph-line, package, account, search, tag,
    credit-card, globe, gear), humanized report slugs
    (customer-registration-trendsCustomer Registration Trends), and moved the SDK report description into the
    right-hand description slot in place of the trailing emoji.
  • Description color (.vscode/settings.json) — lightened
    workspace list.descriptionForeground /
    list.deemphasizedForeground to #9a9a9a so report subtext
    recedes from the title.
  • Hero eyebrow accent (src/cip-analytics/cip-styles.css) —
    switched the B2C-DX ANALYTICS eyebrow on Query Builder and
    Entity Browser from --vscode-descriptionForeground to
    --cip-accent, picking up the theme's link/blue token.

Testing

  • tsc --noEmit passes for packages/b2c-vs-extension.
  • Reloaded the Extension Development Host and verified:
    • Curated Reports categories render with their new icons;
      report rows show humanized titles + descriptions.
    • Description text in the tree reads in the lighter grey.
    • Query Builder and Entity Browser headers show the eyebrow in
      the theme accent (verified in light + dark themes).

Dependencies

  • No net-new third-party dependencies were added
  • If net-new third-party dependencies were added,
    rationale/discussion is included and 3pl-approved is set by a
    maintainer

  • Tests pass (pnpm test)
  • Code is formatted (pnpm run format)

charithaT07 and others added 4 commits April 30, 2026 08:28
* @W-22210602: Adding CIP analytics to a new menu

* @W-22210602: Adding Analytics report support in VS Code extension

* @W-22210602: Adding Analytics report support in VS Code extension

* fixing the result exports in csv and json

* @W-22210602: Adding Analytics report support in VS Code extension

* @W-22210602: Adding Analytics report support in VS Code extension

* @W-22210602: Adding Analytics report support in VS Code extension

* @W-22210602: Adding Analytics report support in VS Code extension

* cip analytics report ux refinements

---------

Co-authored-by: CharithaT07 <charitha.tadakanti777@gmail.com>
@charithaT07 charithaT07 changed the title W 22210602 cip analytics vs extension @W-22210602 cip analytics vs extension May 6, 2026
@charithaT07 charithaT07 changed the title @W-22210602 cip analytics vs extension @W-22210602 cip analytics VS extension May 6, 2026
@charithaT07 charithaT07 marked this pull request as ready for review May 6, 2026 15:59
@charithaT07 charithaT07 marked this pull request as draft May 7, 2026 11:27
@github-actions github-actions Bot added the needs-3pl-review PR introduces net-new third-party dependencies and needs discussion label May 13, 2026
@charithaT07 charithaT07 marked this pull request as ready for review May 13, 2026 17:38
@clavery clavery added 3pl-approved Maintainer approved net-new third-party dependency additions and removed needs-3pl-review PR introduces net-new third-party dependencies and needs discussion labels May 22, 2026
Copy link
Copy Markdown
Collaborator

@clavery clavery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far. Few initial notes:

This item I added recently to support our safety mode and analytics. Should be a simple mechanical fix.

  1. Doesn't use registerSafeCommand (safety.ts) — none of the 11 commands are gated.
    api-browser/index.ts, sandbox-tree/, webdav-tree/, code-sync/ all route through registerSafeCommand. CIP uses vscode.commands.registerCommand directly (src/cip-analytics/index.ts:74-183). Most CIP commands are read-only so safety policy probably wouldn't block them, but bypassing the wrapper also means no
    markFeatureUsed() telemetry fires for any CIP command. That's the bigger miss — the analytics feature itself is invisible to your usage analytics.

This item is a build consistency issue:

Styles shipped as 3,495-line raw CSS in src/cip-analytics/cip-styles.css with a special-case .vscodeignore exception (!src/cip-analytics/*.css).
The webview JS goes through esbuild → dist/webview-ui/, but the stylesheet is loaded straight from src/. That's an inconsistency — you reach back into src/ from a packaged extension. Nothing is broken (the .vscodeignore exception keeps it shipped), but it would be cleaner to either:

  • Have esbuild copy/bundle it into dist/webview-ui/cip-styles.css (matches the JS), or
  • Use the loader: {'.css': 'text'} rule already in webviewBuildOptions and import './cip-styles.css' from each entry — the rule is even configured already, but no one imports the CSS file. Right now it's dead-config.

Documentation — README/CHANGELOG entry, plus a new "VS Code IDE Integration" section in the existing analytics-reports-cip-ccac.md guide.

I'll have some UX/UI notes later

…ages

These two pages were falling back to the site-wide default meta
description. Add concise page-specific descriptions and a doc-only
changeset.
kevinxh and others added 4 commits May 25, 2026 14:52
#450)

- qs: 6.14.1 → 6.15.2 (fixes CWE-770 resource allocation without limits)
- picomatch: 2.3.1 → 2.3.2, 4.0.3 → 4.0.4 (fixes ReDoS vulnerability)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3pl-approved Maintainer approved net-new third-party dependency additions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants