Make the Read Receipts dialog scrollable again#631
Open
Septicity wants to merge 1 commit intoSableClient:devfrom
Open
Make the Read Receipts dialog scrollable again#631Septicity wants to merge 1 commit intoSableClient:devfrom
Septicity wants to merge 1 commit intoSableClient:devfrom
Conversation
…up is scrollable again (temporary)
Contributor
Author
|
Looks like some jank from merging the old code made it through, as well as some linter troubles... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
At some point between commits 43cb531 and f4cc4d5, in the process of switching various UI elements into unified modals, the read receipts modal (specifically the one that opens from an individual message's context menu) lost its ability to be scrolled through.
In this patch, I've reverted that specific component to its old form, both to immediately return the functionality and to provide a useful reference state for the process of creating a more polished fix.
I recommend directly patching this pull request to properly unify the modals first, but it should be functional enough on its own to be implemented as an immediate fix if you prefer.
Type of change
Checklist:
AI disclosure: