Skip to content

Fix "sticky scrolling" issue in encrypted rooms with many PMP messages#626

Merged
7w1 merged 1 commit intoSableClient:devfrom
Septicity:dev
Apr 2, 2026
Merged

Fix "sticky scrolling" issue in encrypted rooms with many PMP messages#626
7w1 merged 1 commit intoSableClient:devfrom
Septicity:dev

Conversation

@Septicity
Copy link
Copy Markdown
Contributor

Description

Previously, in encrypted rooms with many PMP messages, scrolling to the bottom of the page resulted in the view "sticking"; you would need to scroll either very quickly or manually with the scrollbar to get "unstuck".

This stemmed from a part of the logic for grouping PMP messages together in encrypted rooms; a timeline update seemed to be erroneously triggered, re-rendering the timeline repeatedly (effectively sending you back to the bottom).

I've removed the offending line, and the original functionality of the change (i.e. PMP messages continuing to be grouped both as they are sent, edited, and re-rendered) seems to still be present.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

AI disclosure:

  • Partially AI assisted (clarify which code was AI assisted and briefly explain what it does).
  • Fully AI generated (explain what all the generated code does in moderate detail).

@Septicity Septicity requested review from 7w1 and hazre as code owners April 2, 2026 02:15
@7w1 7w1 added this pull request to the merge queue Apr 2, 2026
Merged via the queue into SableClient:dev with commit 8c62746 Apr 2, 2026
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants