Fix "sticky scrolling" issue in encrypted rooms with many PMP messages#626
Merged
7w1 merged 1 commit intoSableClient:devfrom Apr 2, 2026
Merged
Fix "sticky scrolling" issue in encrypted rooms with many PMP messages#6267w1 merged 1 commit intoSableClient:devfrom
7w1 merged 1 commit intoSableClient:devfrom
Conversation
7w1
approved these changes
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Previously, in encrypted rooms with many PMP messages, scrolling to the bottom of the page resulted in the view "sticking"; you would need to scroll either very quickly or manually with the scrollbar to get "unstuck".
This stemmed from a part of the logic for grouping PMP messages together in encrypted rooms; a timeline update seemed to be erroneously triggered, re-rendering the timeline repeatedly (effectively sending you back to the bottom).
I've removed the offending line, and the original functionality of the change (i.e. PMP messages continuing to be grouped both as they are sent, edited, and re-rendered) seems to still be present.
Type of change
Checklist:
AI disclosure: