Merged
Conversation
7w1
approved these changes
Mar 22, 2026
Member
|
Doesn't this ignore the show unread counts setting? Edit: Wait what i didn't approve these changes github is gaslighting me |
75d7707 to
b7f9b85
Compare
Contributor
Deploying with
|
| Status | Preview URL | Commit | Alias | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! | https://pr-484-sable.raspy-dream-bb1d.workers.dev | d881769 | pr-484 |
Wed, 25 Mar 2026 14:59:37 GMT |
Member
Author
|
It's good now btw |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This fixes unread badge positioning by deriving sidebar badge layout from the same settings-aware mode that decides whether unread badges render as dots or counts, so toggling badge display no longer leaves the offset wrong. It also includes the related unread count formatting cleanup, an Appearance toggle for large-count badge behavior, and replaces
millifydependency with a sharedIntl.NumberFormatcompact formatter.Screenshots
Type of change
Checklist:
AI disclosure: