Skip to content

fix: unread badge positioning #484

Merged
7w1 merged 6 commits intodevfrom
hazre/fix/sidebar-count-badge-positioning
Mar 25, 2026
Merged

fix: unread badge positioning #484
7w1 merged 6 commits intodevfrom
hazre/fix/sidebar-count-badge-positioning

Conversation

@hazre
Copy link
Member

@hazre hazre commented Mar 22, 2026

Description

This fixes unread badge positioning by deriving sidebar badge layout from the same settings-aware mode that decides whether unread badges render as dots or counts, so toggling badge display no longer leaves the offset wrong. It also includes the related unread count formatting cleanup, an Appearance toggle for large-count badge behavior, and replaces millify dependency with a shared Intl.NumberFormat compact formatter.

Screenshots

image

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

AI disclosure:

  • Partially AI assisted (clarify which code was AI assisted and briefly explain what it does).
  • Fully AI generated (explain what all the generated code does in moderate detail).

@hazre hazre requested a review from 7w1 as a code owner March 22, 2026 23:02
@hazre hazre added the ui change this pr introduces ui changes label Mar 22, 2026
@7w1
Copy link
Member

7w1 commented Mar 23, 2026

Doesn't this ignore the show unread counts setting?

Edit: Wait what i didn't approve these changes github is gaslighting me

Copy link
Member

@7w1 7w1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

respect unread counts

@Rosy-iso Rosy-iso self-requested a review March 23, 2026 09:27
@hazre hazre force-pushed the hazre/fix/sidebar-count-badge-positioning branch from 75d7707 to b7f9b85 Compare March 25, 2026 14:26
@hazre hazre changed the title fix: unify sidebar count badge positioning Fix unread badge positioning when switching between dots and counts Mar 25, 2026
@hazre hazre requested a review from 7w1 March 25, 2026 14:48
@github-actions
Copy link
Contributor

Deploying with  Cloudflare Workers  Cloudflare Workers

Status Preview URL Commit Alias Updated (UTC)
✅ Deployment successful! https://pr-484-sable.raspy-dream-bb1d.workers.dev d881769 pr-484 Wed, 25 Mar 2026 14:59:37 GMT

@hazre hazre changed the title Fix unread badge positioning when switching between dots and counts fix: unread badge positioning Mar 25, 2026
@hazre
Copy link
Member Author

hazre commented Mar 25, 2026

It's good now btw

Copy link
Member

@7w1 7w1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

crazy easter egg :3

@7w1 7w1 enabled auto-merge March 25, 2026 17:54
@7w1 7w1 disabled auto-merge March 25, 2026 17:56
@7w1 7w1 merged commit 2c7433e into dev Mar 25, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ui change this pr introduces ui changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants