Use KERNEL_OUTPUTDIR for integrated initramfs configuration #46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
--integrated-initramfs builds the kernel in 2 passes, and modifies the kernel configuration in-between.
However it used ${KERNEL_DIR}/.config, which is in the kernel source tree. While this did work for in-tree builds, it made out-of-tree builds fail since the source tree then appeared unclean (and the written .config file only contained the CONFIG_INITRAMFS_* items anyway).
This commit switches to ${KERNEL_OUTPUTDIR}/.config which is the right path both for in-tree and out-of-tree builds.
Also, some additional quotes are added.
Author
|
Out of the scope of this PR as I don't know how it should be fixed, but the |
Author
|
Pretty please fix this? :) |
laomaiweng
added a commit
to laomaiweng/laomaiweng-overlay
that referenced
this pull request
Oct 18, 2017
Apply patch for PRs Sabayon/genkernel-next#46 and Sabayon/genkernel-next#49. Package-Manager: Portage-2.3.11, Repoman-2.3.3 RepoMan-Options: --ignore-arches Manifest-Sign-Key: 0xAA0929D0263BE9D6C260BDC5FF79BF270F5F912C
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--integrated-initramfsbuilds the kernel in 2 passes, and modifies the kernel configuration in-between.However it uses
${KERNEL_DIR}/.config, which is in the kernel source tree. While this does work for in-tree builds, it makes out-of-tree builds fail since the source tree then appears unclean (and the written.configfile only contains theCONFIG_INITRAMFS_*items anyway).This PR switches to
${KERNEL_OUTPUTDIR}/.configwhich should be the right path both for in-tree and out-of-tree builds.