refactor: NCP ObjectStorage 설정#150
Merged
Merged
Conversation
There was a problem hiding this comment.
Code Review
This pull request adds environment variables for NCP (Naver Cloud Platform) access and storage to the production Docker Compose configuration. The feedback suggests using mandatory environment variable syntax to ensure these keys are provided at runtime and recommends adopting more secure secret management practices for sensitive credentials.
Comment on lines
+82
to
+84
| NCP_ACCESS_KEY: ${NCP_ACCESS_KEY} | ||
| NCP_SECRET_KEY: ${NCP_SECRET_KEY} | ||
| NCP_BUCKET_NAME: ${NCP_BUCKET_NAME} |
There was a problem hiding this comment.
운영 환경에서는 NCP 액세스 키와 버킷 이름과 같은 필수 설정이 누락되지 않도록 보장하는 것이 중요합니다. 리포지토리 규칙에 따라 YAML 설정 파일에서 환경 변수를 사용해야 하며, ${VARIABLE:?error} 구문을 활용하면 환경 변수가 설정되지 않았을 때 배포 단계에서 에러를 발생시켜 잘못된 설정으로 애플리케이션이 실행되는 것을 방지할 수 있습니다.
NCP_ACCESS_KEY: ${NCP_ACCESS_KEY:?NCP_ACCESS_KEY must be set}
NCP_SECRET_KEY: ${NCP_SECRET_KEY:?NCP_SECRET_KEY must be set}
NCP_BUCKET_NAME: ${NCP_BUCKET_NAME:?NCP_BUCKET_NAME must be set}References
- 환경별 설정 시 YAML 파일에서 주석 처리 대신 기본값이 포함된 환경 변수를 사용해야 합니다.
| COOKIE_SAME_SITE: ${COOKIE_SAME_SITE} | ||
| COOKIE_DOMAIN: ${COOKIE_DOMAIN} | ||
| NCP_ACCESS_KEY: ${NCP_ACCESS_KEY} | ||
| NCP_SECRET_KEY: ${NCP_SECRET_KEY} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔥ISSUE
NCP ObjectStorage 설정