Add read_system_setting_worker #212
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stvreumi
approved these changes
Jul 30, 2017
icecat2012
reviewed
Jul 31, 2017
Collaborator
icecat2012
left a comment
icecat2012
left a comment
There was a problem hiding this comment.
hmm...
I wonder if do_read_system_setting works correct?
board_py_dir & shutdown & max_db_log & min_db_activity
They seem to be do_read_system_setting's local variables, but not main function's variables.
Can value pass to the main function?
Contributor
Author
|
Sorry, I will change it to global variable. |
Contributor
Author
|
I found that this function doesn't need to fork a child process, and I have not think of a new function to replace it, so I will postpone this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.