Skip to content

Import RT and BH fixes from romeel_dev #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
romeeld wants to merge 97 commits into
base: master
Choose a base branch
from
Open

Import RT and BH fixes from romeel_dev #72

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
97 commits
Select commit Hold shift + click to select a range
5b37991
Begin Kiara rebase from https://github.com/romeeld/swiftsim/tree/master
romeeld Nov 8, 2025
f0e6d35
Add MAGMA2 hydro (including target_neighbours option)
romeeld Nov 8, 2025
2f1e4de
Apply formatting tool
romeeld Nov 8, 2025
c577ce6
Add div_v calculation to MAGMA2 to enable unit tests
romeeld Nov 8, 2025
106c4ec
Merge pull request #1 from kiara-project/romeel_dev
romeeld Nov 10, 2025
abdff25
Merge branch 'SWIFTSIM:master' into romeel_dev
romeeld Nov 11, 2025
c395142
Merge branch 'SWIFTSIM:master' into master
romeeld Nov 11, 2025
acac9f9
Merge branch 'SWIFTSIM:master' into master
romeeld Nov 13, 2025
532e57b
Merge branch 'SWIFTSIM:master' into romeel_dev
romeeld Nov 13, 2025
ac97b17
Add KIARA chemistry and cooling. Compiles but otherwise untested.
romeeld Nov 13, 2025
fc8521d
Merge branch 'master' into romeel_dev
romeeld Nov 13, 2025
2a1096e
Merge pull request #2 from kiara-project/romeel_dev
romeeld Nov 13, 2025
e43a18d
Add Kiara stars and star_formation routines. Compiles but probably do…
romeeld Nov 13, 2025
39f73b5
Merge pull request #3 from kiara-project/romeel_dev
romeeld Nov 13, 2025
97b8d48
Merge branch 'SWIFTSIM:master' into romeel_dev
romeeld Nov 19, 2025
9a5f7de
Merge branch 'SWIFTSIM:master' into master
romeeld Nov 19, 2025
1a4f5d3
Merge branch 'SWIFTSIM:master' into master
romeeld Nov 20, 2025
4aba5b2
Merge branch 'SWIFTSIM:master' into romeel_dev
romeeld Nov 20, 2025
632fe02
Add Kiara feedback and Obsidian BH; full KIARA model now works
romeeld Nov 20, 2025
b65954c
Merge pull request #4 from kiara-project/romeel_dev
romeeld Nov 20, 2025
a6ba1fc
Merge branch 'SWIFTSIM:master' into romeel_dev
romeeld Nov 25, 2025
d03df6f
Add recoupling; refactor grackle for compatibility with RT
romeeld Nov 25, 2025
e31241e
Merge branch 'SWIFTSIM:master' into master
romeeld Nov 25, 2025
630d42b
Merge pull request #5 from kiara-project/romeel_dev
romeeld Nov 25, 2025
008761e
Fix compilation problems with static functions
MatthieuSchaller Nov 26, 2025
9b1999b
Fix debugging check error in the Obsidian checks
MatthieuSchaller Nov 26, 2025
5e9e9d9
Applied the code formatting script to help diffing between versions
MatthieuSchaller Nov 26, 2025
31d231f
Merge pull request #6 from kiara-project/matthieu_compile_fixes
romeeld Nov 26, 2025
5817faf
Merge branch 'SWIFTSIM:master' into master
romeeld Nov 26, 2025
cd03385
Merge branch 'SWIFTSIM:master' into romeel_dev
romeeld Nov 26, 2025
e46e1cb
Merge pull request #8 from kiara-project/master
romeeld Nov 26, 2025
e408342
Let the code compile with just hydro
MatthieuSchaller Nov 26, 2025
0e8f302
KIARA-RT first push. Compiles but does not work.
romeeld Nov 26, 2025
f9ee97a
Merge pull request #9 from kiara-project/romeel_dev
romeeld Nov 26, 2025
f4637aa
Make previous commit compatible when RT is off
romeeld Nov 26, 2025
e0113b1
Merge pull request #10 from kiara-project/romeel_dev
romeeld Nov 26, 2025
30f5869
Remove files that should have been committed
MatthieuSchaller Nov 27, 2025
e5dabe6
Fix compilation problems when configuring with subgrid=KIARA
MatthieuSchaller Nov 27, 2025
aa00461
Add the proper includes in the unit tests
MatthieuSchaller Nov 27, 2025
86bc2ec
Make the symmetry and MPI-rules test work
MatthieuSchaller Nov 27, 2025
8e9c9a2
Fix a bug in the MAGMA implementation where the du/dt_cond term was n…
MatthieuSchaller Nov 27, 2025
bb617ca
Expand the symmetry test to properly cover the KIARA chemistry model
MatthieuSchaller Nov 27, 2025
e397140
Merge branch 'SWIFTSIM:master' into romeel_dev
romeeld Nov 27, 2025
4eeca72
Merge branch 'SWIFTSIM:master' into master
romeeld Nov 27, 2025
1aa244e
Merge pull request #11 from kiara-project/hydro_tests
romeeld Nov 27, 2025
df70530
Merge pull request #13 from kiara-project/master
romeeld Nov 27, 2025
c78aa5f
Add option for capping BH mass in Bondi rate; remove FIRE_eta_lower_s…
romeeld Nov 27, 2025
4134011
Merge pull request #14 from kiara-project/romeel_dev
romeeld Nov 27, 2025
94d52f7
Do not place the recoupled particle back onto the timeline. They are …
MatthieuSchaller Dec 1, 2025
09da229
Follow the convention of the rest of the code regarding i/o names so …
MatthieuSchaller Dec 1, 2025
af339d1
Indicate whether a particle is decoupled or not when calling magma's …
MatthieuSchaller Dec 1, 2025
9416fa3
Make git ignore the side tables used for Kiara
MatthieuSchaller Dec 1, 2025
7532928
Change CoolingTime to CoolingTimes in the snapshots to match the main…
MatthieuSchaller Dec 1, 2025
5affc77
Only do the expensive math operations in the ghost loop in prepare_gr…
MatthieuSchaller Dec 3, 2025
57a291f
Fix merge conflicts in runner_doiact_functions_hydro.h
romeeld Dec 4, 2025
781844d
Fix handling of lum_thresh_always_jet in Obsidian; remove v_full from…
romeeld Dec 4, 2025
f2f85cb
Merge pull request #16 from kiara-project/romeel_dev
romeeld Dec 4, 2025
2ffd4e0
Fix previous commit, forgot to remove xparts declarations
romeeld Dec 4, 2025
dd7184f
Merge pull request #17 from kiara-project/romeel_dev
romeeld Dec 4, 2025
7504a32
Add in KIARART option; uses native Kiara/grackle cooling. Works witho…
romeeld Dec 4, 2025
fc7d78c
Merge pull request #18 from kiara-project/romeel_dev
romeeld Dec 4, 2025
9726ede
Fix compilation typo
MatthieuSchaller Dec 5, 2025
d05c515
Merge branch 'SWIFTSIM:master' into master
romeeld Dec 9, 2025
a053cda
Merge branch 'SWIFTSIM:master' into romeel_dev
romeeld Dec 9, 2025
0357d60
Merge branch 'master' into fixes_matthieu
romeeld Dec 11, 2025
29a1a6b
Merge pull request #15 from kiara-project/fixes_matthieu
romeeld Dec 11, 2025
83a01b7
Merge pull request #20 from kiara-project/romeel_dev
romeeld Dec 11, 2025
9dc2a2c
Merge pull request #21 from kiara-project/master
romeeld Dec 11, 2025
d7556e2
Fix double definition of hydro_prepare_gradient; new cooling I/O stuf…
romeeld Dec 11, 2025
0f1d535
Merge branch 'SWIFTSIM:master' into romeel_dev
romeeld Dec 23, 2025
c233d33
Refactor BH suppression and cold inflow criterion; revert hydro_prepa…
romeeld Dec 23, 2025
50d21e1
Merge branch 'SWIFTSIM:master' into romeel_dev
romeeld Dec 29, 2025
54cfc27
Merge branch 'SWIFTSIM:master' into romeel_dev
romeeld Jan 8, 2026
a744351
Merge branch 'SWIFTSIM:master' into romeel_dev
romeeld Jan 9, 2026
76b4997
Fix BH seeding in FOF_GALAXIES case where we use stellar (not halo) m…
romeeld Jan 9, 2026
4cbc3cb
Resolve merge conflict with main SWIFT in fof, star_formation
romeeld Jan 19, 2026
cee3ab1
Merge branch 'SWIFTSIM:master' into romeel_dev
romeeld Jan 20, 2026
9e250fe
Merge branch 'SWIFTSIM:master' into romeel_dev
romeeld Jan 21, 2026
db0061f
Merge branch 'SWIFTSIM:master' into romeel_dev
romeeld Jan 25, 2026
2322c17
Merge branch 'SWIFTSIM:master' into romeel_dev
romeeld Jan 30, 2026
894ef5f
Fix merge conflict in configure.ac
romeeld Feb 8, 2026
9685f7c
Merge branch 'SWIFTSIM:master' into romeel_dev
romeeld Feb 11, 2026
11bae7c
Merge branch 'SWIFTSIM:master' into romeel_dev
romeeld Feb 12, 2026
0cac9d0
Merge branch 'SWIFTSIM:master' into romeel_dev
romeeld Feb 14, 2026
da402d2
Merge branch 'SWIFTSIM:master' into romeel_dev
romeeld Feb 17, 2026
e3c84ef
Merge branch 'SWIFTSIM:master' into romeel_dev
romeeld Feb 21, 2026
fd01e95
Merge branch 'SWIFTSIM:master' into romeel_dev
romeeld Feb 24, 2026
980ae02
Merge branch 'SWIFTSIM:master' into romeel_dev
romeeld Feb 25, 2026
36f509d
Merge branch 'SWIFTSIM:master' into romeel_dev
romeeld Feb 28, 2026
c5e7818
Merge branch 'SWIFTSIM:master' into romeel_dev
romeeld Mar 6, 2026
7bfa25a
Merge branch 'SWIFTSIM:master' into romeel_dev
romeeld Mar 11, 2026
9f062f9
Fix configure bug; add G0 options; turn off BH torque accr when far f…
romeeld Mar 11, 2026
d642591
Merge branch 'romeel_dev' of https://github.com/kiara-project/SWIFT i…
romeeld Mar 11, 2026
dd396dc
Merge branch 'SWIFTSIM:master' into romeel_dev
romeeld Mar 12, 2026
25918d0
Merge branch 'SWIFTSIM:master' into romeel_dev
romeeld Mar 14, 2026
eb856a5
Fix T output; add volume correction for RT
romeeld Mar 17, 2026
95bca10
Fix options on v_kick for quasar/slim disk mode
romeeld Mar 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,8 @@ examples/SubgridTests/CosmologicalStellarEvolution/StellarEvolutionSolution*
examples/SmallCosmoVolume/SmallCosmoVolume_DM/power_spectra
examples/SmallCosmoVolume/SmallCosmoVolume_cooling/snapshots/
examples/SmallCosmoVolume/SmallCosmoVolume_hydro/snapshots/
examples/**/chem5
examples/**/CloudyData_UVB=FG2011_shielded.h5
examples/**/CloudyData_UVB=HM2012.h5
examples/**/CloudyData_UVB=HM2012_shielded.h5
examples/**/CloudyData_UVB=HM2012_high_density.h5
Expand Down
Loading