Skip to content

Conversation

@norbertbuchmueller
Copy link

One often uses the metadata envvars to construct a URL to the Concourse build page. This PR makes it easier - by moving the logic of that into this resource.

@norbertbuchmueller
Copy link
Author

@regevbr what's your opinion of the proposed changes?

@regevbr
Copy link
Contributor

regevbr commented Sep 20, 2018

@norbertbuchmueller thanks for the contribution and Sorry for the delay,

I don't mind adding those "variables" but please refactor the code so you won't have to hack the values into the environment - create a method to extract the env values for the existing variables and pass the values directly to the handle prop method, then in your props, just pass the values without calling the helper method.

Also please make sure the tests pass after you make the changes.

@ezraroi what do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants