Closed
Conversation
…tics Change label element from span to p and add fallback to label prop when title is not provided. Co-Authored-By: Claude <noreply@anthropic.com>
Remove test that checked for absence of title attribute, as the component now uses label as fallback for title when not explicitly defined. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
codingwithdani
requested review from
andresin87,
andresz1,
kikoruiz and
sui-bot
as code owners
|
Add test to verify that title attribute is not rendered when not explicitly provided, ensuring clean DOM without unnecessary attributes. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Category/Component
TASK:
Description, Motivation and Context
Fix AtomTag title not showing on hover
Previously, the Atom Tag label did not display the title tooltip when hovering over the tag. This was caused by the label being rendered inside a span, which prevented the tooltip from appearing correctly in this context.
To fix this, the label element was changed from span to p, allowing the title attribute to work as expected when hovering over the tag.
Result
The tag now correctly shows the title tooltip on hover.
Types of changes
Screenshots - Animations