feat(components/atom/videoPlayer): use static imports for vite compatibility#2964
Merged
feat(components/atom/videoPlayer): use static imports for vite compatibility#2964
Conversation
|
tomasmax
approved these changes
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Category/Component
🔍 ShowDescription, Motivation and Context
Fix SSR suspension and Vite compatibility issues
Changes
Technical Details
Before:
lazy(() => import('../components/${videoType.PLAYER_COMPONENT}.js'))- Dynamic imports with template strings (Vite can't analyze)<Suspense>caused suspension errors during SSRAfter:
PLAYER_COMPONENTSobjectBackwards Compatibility
✅ Fully backwards compatible - no breaking changes to public API