Use generic trades query for owner endpoint#110
Merged
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Collaborator
Author
How to use the Graphite Merge QueueAdd the label add-to-gt-merge-queue to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
1 task
graphite-app
Bot
force-pushed
the
feature/order-endpoint-batch-trade-query
branch
2 times, most recently
from
b4fac6d to
f4de41e
Compare
graphite-app
Bot
force-pushed
the
feature/trades-owner-generic-query
branch
from
28254bc to
ff1f985
Compare
JuaniRios
approved these changes
May 20, 2026
findolor
force-pushed
the
feature/order-endpoint-batch-trade-query
branch
from
f4de41e to
73a5ca6
Compare
findolor
force-pushed
the
feature/trades-owner-generic-query
branch
from
ff1f985 to
3c3cf6a
Compare
findolor
force-pushed
the
feature/order-endpoint-batch-trade-query
branch
from
73a5ca6 to
1c569cb
Compare
findolor
force-pushed
the
feature/trades-owner-generic-query
branch
2 times, most recently
from
660ad1a to
b60ed4d
Compare
findolor
force-pushed
the
feature/order-endpoint-batch-trade-query
branch
from
1c569cb to
e8e2ed7
Compare
findolor
force-pushed
the
feature/trades-owner-generic-query
branch
from
b60ed4d to
6e19d52
Compare
findolor
force-pushed
the
feature/order-endpoint-batch-trade-query
branch
2 times, most recently
from
0648e86 to
2df41e9
Compare
findolor
force-pushed
the
feature/trades-owner-generic-query
branch
2 times, most recently
from
14e1aa8 to
69f89e0
Compare
findolor
force-pushed
the
feature/order-endpoint-batch-trade-query
branch
2 times, most recently
from
bafb7ff to
8288d45
Compare
findolor
force-pushed
the
feature/trades-owner-generic-query
branch
from
69f89e0 to
7cd65c5
Compare
findolor
force-pushed
the
feature/order-endpoint-batch-trade-query
branch
from
8288d45 to
9d05162
Compare
findolor
force-pushed
the
feature/trades-owner-generic-query
branch
from
75f091c to
6e676d2
Compare
findolor
force-pushed
the
feature/order-endpoint-batch-trade-query
branch
2 times, most recently
from
511bbd2 to
9003bad
Compare
findolor
force-pushed
the
feature/trades-owner-generic-query
branch
2 times, most recently
from
6fd79e5 to
64958e4
Compare
findolor
force-pushed
the
feature/order-endpoint-batch-trade-query
branch
from
9003bad to
c6e1a8a
Compare
findolor
force-pushed
the
feature/order-endpoint-batch-trade-query
branch
from
c6e1a8a to
eeb2321
Compare
findolor
force-pushed
the
feature/trades-owner-generic-query
branch
2 times, most recently
from
5ff5da1 to
858932d
Compare
findolor
force-pushed
the
feature/order-endpoint-batch-trade-query
branch
from
eeb2321 to
3bd8ca1
Compare
This was referenced May 22, 2026
findolor
force-pushed
the
feature/order-endpoint-batch-trade-query
branch
from
3bd8ca1 to
d5ba372
Compare
findolor
force-pushed
the
feature/trades-owner-generic-query
branch
from
6ca6ad4 to
3bc07c8
Compare
findolor
force-pushed
the
feature/order-endpoint-batch-trade-query
branch
from
d5ba372 to
8758d0a
Compare
findolor
force-pushed
the
feature/trades-owner-generic-query
branch
from
5996c20 to
a4dcac7
Compare
findolor
force-pushed
the
feature/order-endpoint-batch-trade-query
branch
from
8758d0a to
d03ce25
Compare
findolor
force-pushed
the
feature/trades-owner-generic-query
branch
3 times, most recently
from
b106217 to
a7f8106
Compare
findolor
force-pushed
the
feature/order-endpoint-batch-trade-query
branch
from
d03ce25 to
9b39e94
Compare
0xgleb
approved these changes
May 26, 2026
findolor
force-pushed
the
feature/trades-owner-generic-query
branch
from
a7f8106 to
7678452
Compare
findolor
force-pushed
the
feature/order-endpoint-batch-trade-query
branch
from
9b39e94 to
7a5bdbf
Compare
Merge activity
|
## Summary
- route `GET /v1/trades/{owner}` through the generic `get_trades` SDK path with an owner filter
- preserve existing pagination, time filter, exact count, and response shape
## Linear
Part of RAI-580.
## Benchmark context
Local benchmark against the bootstrapped DB showed the owner-specific SDK path taking roughly 3-4s for 20-row pages. Using the generic owner-filtered trades query reduced the same endpoint to roughly 1-2.7s while keeping the same pagination totals.
## Validation
- `nix develop -c cargo fmt`
- `nix develop -c cargo check`
- `nix develop -c rainix-rs-static`
graphite-app
Bot
force-pushed
the
feature/order-endpoint-batch-trade-query
branch
from
7a5bdbf to
0924bce
Compare
graphite-app
Bot
force-pushed
the
feature/trades-owner-generic-query
branch
from
7678452 to
1c151e2
Compare
graphite-app
Bot
changed the base branch from
feature/order-endpoint-batch-trade-query
to
main
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GET /v1/trades/{owner}through the genericget_tradesSDK path with an owner filterLinear
Part of RAI-580.
Benchmark context
Local benchmark against the bootstrapped DB showed the owner-specific SDK path taking roughly 3-4s for 20-row pages. Using the generic owner-filtered trades query reduced the same endpoint to roughly 1-2.7s while keeping the same pagination totals.
Validation
nix develop -c cargo fmtnix develop -c cargo checknix develop -c rainix-rs-static