Skip to content

Conversation

@sssd-bot
Copy link
Contributor

@sssd-bot sssd-bot commented Jan 9, 2026

This is an automatic backport of PR#8280 adding enumeration system tests to branch sssd-2-10, created by @danlavu.

Please make sure this backport is correct.

Note

The commits were cherry-picked without conflicts.

You can push changes to this pull request

git remote add sssd-bot git@github.com:sssd-bot/sssd.git
git fetch sssd-bot refs/heads/SSSD-sssd-backport-pr8280-to-sssd-2-10
git checkout SSSD-sssd-backport-pr8280-to-sssd-2-10
git push sssd-bot SSSD-sssd-backport-pr8280-to-sssd-2-10 --force

Original commits
160bbb3 - adding parametrized enumeration enabled tests
5b5dce2 - removing intg enumeration tests.

Backported commits

  • 86a4e42 - adding parametrized enumeration enabled tests
  • aae9804 - removing intg enumeration tests.

Original Pull Request Body

Dan Lavu added 2 commits January 9, 2026 19:52
Reviewed-by: Jakub Vávra <jvavra@redhat.com>
Reviewed-by: Tomáš Halman <thalman@redhat.com>
(cherry picked from commit 160bbb3)
Reviewed-by: Jakub Vávra <jvavra@redhat.com>
Reviewed-by: Tomáš Halman <thalman@redhat.com>
(cherry picked from commit 5b5dce2)
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request is an automatic backport that replaces old integration tests for enumeration with new system tests. This is achieved by parameterizing several existing system tests in test_nss.py to run with enumeration enabled. The changes are logical and improve test coverage for the enumeration feature.

I have one suggestion to improve the maintainability of the newly added test logic by refactoring duplicated code into a pytest fixture. This would make the test suite cleaner and easier to maintain in the long run.

Copy link
Contributor

@jakub-vavra-cz jakub-vavra-cz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants