-
Notifications
You must be signed in to change notification settings - Fork 271
[autobackport: sssd-2-9] adding subid test #8294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: sssd-2-9
Are you sure you want to change the base?
[autobackport: sssd-2-9] adding subid test #8294
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request backports a new test file, src/tests/system/tests/test_ipa.py, which adds a comprehensive suite of system tests for SSSD's integration with FreeIPA. The new tests cover a wide range of features, including SSH public keys, ID views, HBAC rules, smart card authentication, and the subordinate ID (subid) functionality mentioned in the PR title. While the majority of the tests are well-structured, I've identified two tests related to ID views that don't actually validate SSSD's behavior on the client. Instead, they test the IPA server's command-line interface. These tests should be either corrected to verify client-side functionality or removed as they are out of scope for the SSSD test suite.
|
@alexey-tikhonov Did you want this subid test ported to 2-9? |
Imo it makes sense. |
5f9a380 to
ddb1de7
Compare
jakub-vavra-cz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@jakub-vavra-cz, test is failing to start: @danlavu, please rebase. |
This is an automatic backport of PR#8225 adding subid test to branch sssd-2-9, created by @danlavu.
Caution
@danlavu The patches did not apply cleanly. It is necessary to resolve conflicts before merging this pull request. Commits that introduced conflict are marked with
CONFLICT!.You can push changes to this pull request
Original commits
449913a - adding subid test
Backported commits
Conflicting Files Information (check for deleted and re-added files)
Original Pull Request Body