-
Notifications
You must be signed in to change notification settings - Fork 20
fixing tox formatting complaints #229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @danlavu, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request primarily focuses on addressing code formatting complaints identified by Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request addresses formatting complaints identified by the tox tool. The changes primarily involve removing unnecessary parentheses and realigning multiline strings for better readability and adherence to code style guidelines. The changes span across multiple files, ensuring consistency throughout the codebase.
| result = self.host.conn.expect(rf""" | ||
| set timeout {DEFAULT_AUTHENTICATION_TIMEOUT} | ||
| set prompt "\n.*\[#\$>\] $" | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
medium: Removing the unnecessary indentation and parentheses around the multiline string improves readability and aligns with common Pythonic style. This change simplifies the code and makes it easier to maintain.
| result = self.host.conn.expect(rf""" | |
| set timeout {DEFAULT_AUTHENTICATION_TIMEOUT} | |
| set prompt "\n.*\[#\$>\] $" | |
| result = self.host.conn.expect(rf""" | |
| set timeout {DEFAULT_AUTHENTICATION_TIMEOUT} | |
| set prompt "\n.*[#\$>] $" | |
| puts "expect result: Unexpected code path" | ||
| exit 203 | ||
| """ | ||
| ) | ||
| """) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No description provided.