Update use of tesswcs to decrease runtime #16
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@jorgemarpa Please could you review and merge this PR at your earliest convenience. |
jorgemarpa
reviewed
Jul 9, 2025
Collaborator
jorgemarpa
left a comment
jorgemarpa
left a comment
There was a problem hiding this comment.
This looks good to me. I left a small comment regarding data frame concatenation, but it doesn't change the result.
Comment on lines
+164
to
+166
| df = concat( | ||
| [df, result[["time", "Sector", "Camera", "CCD", "Column", "Row"]]] | ||
| ) |
Collaborator
There was a problem hiding this comment.
I'm not sure which is faster, if doing a concatenation each time in the for loop vs appending to a list and and then concatenating after the loop.
df = []
for ... in ...:
...
...
df.append(result[...])
df = pd.concat(df, axis=0)
Contributor
Author
There was a problem hiding this comment.
I just tested this and the two methods take the same time to run, so I suggest we leave the code as is.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, we update the use of
tesswcsto significantly decrease runtime.We use the function
get_pixel_locations()function fromtesswcs. Previously, we were calling this at every time. However, in this update, we now call it once per unique queried sector. This significantly decreases the runtime and gives the same result.