-
Notifications
You must be signed in to change notification settings - Fork 1
Motor Calibration #105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
joshuasrjc
wants to merge
8
commits into
dev
Choose a base branch
from
joshua_motor_calibration
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Motor Calibration #105
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[x] Compiles on PC
[x] Compiles on Teensy
### Added
* ArduinoDummy
* A class with some Arduino dummy functions, so we don't have to use
#ifdef blocks every time we want to call a function like
digitalWrite().
* Memory
* Addresses 0-31 in the memory class are now
used for motor calibration data. Added constants for address
locations.
* Motor
* calibrate()
* For each direction,
calculates the lowest voltage that still turns the motor.
*
loadCalibration()
* Loads the calibration data from memory.
* saveCalibration()
* Saves the calibration data to memory.
* setVoltage()
* Where setMovement() takes a value between -1
and 1, setVoltage() takes an int between 0 and 255. It directly sets the
PWM pin, but not lower than the minimum calibrated voltage.
* RobotIO
* calibrateMotors()
* Calibrates the left and right motors, and
saves the data.
* Timer
* sleep()
* Sleeps for a given
number of seconds.
# Changed
* Controller::debug() now calls
testMotors() instead of mapMaze()
* As long as speed != 0,
Motor::setMovement() will move at the slowest calibrated speed.
*
MouseBot::robotIO is now public.
# Removed
* A bunch of #ifdef blocks
from Motor.cpp
| leftMotor.setMaxSpeed(1.0f); | ||
| timer.start(); | ||
| pid.start(millimeters); | ||
| float avgMove = 10000000000000000000000000000000000000.0f; |
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I hate this line
Collaborator
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's getting removed in the next pull request.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
Changed
Removed