[ALPHA-P1] Single node restart test (NodeId stability) #834
+155
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
26 tasks
- Install libudev-dev, pkg-config, libssl-dev, libdbus-1-dev - Add Rust toolchain with clippy component - Fixes Clippy build failure: libudev-sys dependency missing
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the orchestrator restart determinism integration tests to align with the new encrypted seed storage format, ensuring NodeId and identity stability across restarts while enforcing that key files remain seedless. It also wires in the necessary dependencies and CI setup (SonarCloud workflow environment) to support these changes.
Changes:
- Refactored
test_orchestrator_restart_determinismhelpers to store the master seed in a separate, encrypted JSON record (Argon2 + ChaCha20) instead of in the private key file, and updated reload logic accordingly. - Extended restart/seed persistence/DHT consistency tests to verify that the master seed is loaded from the encrypted seed file, the key file no longer contains seed material, and the encrypted seed file remains stable across restarts.
- Added
argon2,base64, andranddependencies to theintegration-testscrate and updated the SonarCloud GitHub Actions workflow to install system dependencies and a Rust toolchain withclippy.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
tests/integration/test_orchestrator_restart_determinism.rs |
Introduces encrypted seed storage helpers and adjusts identity reload and determinism tests to operate on a seedless key file plus a stable, encrypted seed file while checking NodeId/DID consistency. |
tests/integration/Cargo.toml |
Adds cryptographic and utility dependencies (argon2, base64, rand) needed by the new encrypted seed test helpers. |
Cargo.lock |
Locks in the new integration-test dependencies (argon2, base64 0.22.1, rand 0.8.5) to concrete versions. |
.github/workflows/sonarcloud.yml |
Ensures the SonarCloud job installs required system libraries and a Rust toolchain (with clippy) so Rust analysis can run reliably. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Testing
Relates to #68