fix: Fixed SearchableSelect valid input behaviour and state handling#117
Open
abba-soptim wants to merge 3 commits into
Open
fix: Fixed SearchableSelect valid input behaviour and state handling#117abba-soptim wants to merge 3 commits into
abba-soptim wants to merge 3 commits into
Conversation
… accessDisplayData mismatch
kiph-soptim
requested changes
May 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The SearchableSelect component, used in the ClassEditor for Package input among other places, had an internal state used to save the last valid input. This state was not updated by the InputWithControlButtons, resulting in mismatches in certain cases.
Now the state is synchronized across input field aswell as button actions.
Test Checklist
General Behavior
Global MenuBar
Welcome Page
Editor - MenuBar
Editor - Navigation
Editor - Package View
Editor - Class Editor
Prefixes Page
Changelog Page
Compare Page