feat: GQL node QueryRoot.trendingEventEditions
#119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This new GraphQL node returns the trending event editions, meaning the editions where players set the most records in the last days, with a certain limit. Refs: #102.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a new GraphQL query trendingEventEditions that returns event editions with the most records set in the last days. Additionally, it includes refactoring changes to the game_api crate related to session key handling and adds a limit parameter to the mappack leaderboard query.
Changes:
- Added
trending_event_editionsGraphQL query to find event editions with most recent record activity - Refactored session key handling in
game_apito parseKeytype at environment initialization - Added optional
limitparameter to mappack leaderboard query
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| crates/graphql-api/src/objects/root.rs | Adds new trending_event_editions query method with SQL logic to count records by edition |
| crates/graphql-api/src/objects/mappack.rs | Adds optional limit parameter to leaderboard query |
| crates/game_api/src/main.rs | Simplifies session key usage by removing local variable |
| crates/game_api/src/env.rs | Adds parsing logic to convert session key string to Key type at environment initialization |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This new GraphQL node returns the trending event editions, meaning the editions where players set the most records in the last days, with a certain limit.
Closes: #102.