Skip to content

fix(redis): avoid poisoning Lua SHA cache on transient load failures #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
twisti-dev wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

fix(redis): avoid poisoning Lua SHA cache on transient load failures #56

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions surf-redis-core/src/main/kotlin/dev/slne/surf/redis/util/LuaScriptExecutor.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,12 +12,11 @@ import java.util.concurrent.ConcurrentHashMap

class LuaScriptExecutor private constructor(private val api: RedisApi, private val registry: LuaScriptRegistry) {

private val scriptShas = ConcurrentHashMap<String, Mono<String>>()
private val scriptShas = ConcurrentHashMap<String, String>()
private val script by lazy { api.redissonReactive.getScript(StringCodec.INSTANCE) }

private fun getSha(id: String): Mono<String> = scriptShas.computeIfAbsent(id) {
script.scriptLoad(registry.get(id)).cache()
}
private fun getSha(id: String): Mono<String> = scriptShas[id]?.let { Mono.just(it) }
?: script.scriptLoad(registry.get(id)).doOnNext { scriptShas[id] = it }

fun <R : Any> execute(
id: String,
Expand Down