Harden request/response Pub/Sub envelopes with HMAC verification#54
Draft
twisti-dev wants to merge 1 commit into
Draft
Harden request/response Pub/Sub envelopes with HMAC verification#54twisti-dev wants to merge 1 commit into
twisti-dev wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
SURF_REDIS_REQUEST_HMAC_KEYenvironment variable as the shared secret for envelope signing.RequestEnvelopeandResponseEnvelopewith asignaturefield and compute signatures when publishing requests and responses.handleIncomingRequestandhandleIncomingResponseand reject messages with invalid signatures before processing.Testing
./gradlew :surf-redis-core:compileKotlin -x test, which failed in this environment because the build requires a newer JVM (dependency resolution requires Java 25 while the container has Java 21).SURF_REDIS_REQUEST_HMAC_KEYset.Codex Task