Fix/26.1#52
Open
TheBjoRedCraft wants to merge 2 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Patch release bumping the project to 3.3.1-SNAPSHOT, adjusting the offline player data lookup to use a different on-disk layout (players/data three directories above each world folder), and switching armor assignments in KnightCommand/HatCommand from Kotlin property syntax to explicit setter calls.
Changes:
- Bump project version to
3.3.1-SNAPSHOT. - Change
PLAYER_DATA_FOLDERtoplayers/dataand resolve it from three parent directories above each world folder inplayer-util.kt. - Replace
player.inventory.helmet/chestplate/leggings/boots = ...withsetHelmet(...)/setChestplate(...)/setLeggings(...)/setBoots(...)calls inHatCommandandKnightCommand.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| gradle.properties | Bump version to 3.3.1-SNAPSHOT. |
| src/main/kotlin/dev/slne/surf/essentials/util/util/player-util.kt | Repoint offline player data lookup to a new directory layout three levels above the world folder. |
| src/main/kotlin/dev/slne/surf/essentials/command/KnightCommand.kt | Switch armor slot assignments to explicit setter calls. |
| src/main/kotlin/dev/slne/surf/essentials/command/HatCommand.kt | Switch helmet assignment to explicit setHelmet setter call. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+15
to
+20
| private const val PLAYER_DATA_FOLDER = "players/data" | ||
| private const val PLAYER_GAME_MODE_FILE = "playerGameType" | ||
|
|
||
| private fun getPlayerFile(uuid: UUID): File? { | ||
| for (world in Bukkit.getWorlds()) { | ||
| val worldFolder = world.worldFolder | ||
| val worldFolder = File(File(File(world.worldFolder.parent).parent).parent) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.