fix: prevent entities from passing through locked portals#35
Merged
Keviro merged 2 commits intoversion/1.21.11from Apr 2, 2026
Merged
fix: prevent entities from passing through locked portals#35Keviro merged 2 commits intoversion/1.21.11from
Keviro merged 2 commits intoversion/1.21.11from
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates portal-lock enforcement so locked worlds block portal travel for entities, not just players.
Changes:
- Switch portal listener logic to operate on entity-based portal events and cancel non-player portal attempts in locked worlds.
- Align Canvas (async) portal handling with the same “cancel non-player entities” behavior.
- Bump project snapshot version.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/main/kotlin/dev/slne/surf/essentials/listener/WorldListener.kt | Moves portal lock handling to an entity portal event and cancels non-player entity portal attempts. |
| src/main/kotlin/dev/slne/surf/essentials/listener/CanvasListener.kt | Cancels non-player entity portal attempts when the destination world is locked. |
| gradle.properties | Snapshot version bump. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.