Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a Paper-side “player status access” service to support hiding/visibility checks, and wires it into command argument resolution/suggestions so hidden players don’t appear to unauthorized viewers.
Changes:
- Introduce
CorePlayerStatusAccessAPI + Paper implementation with pluggable access handlers. - Apply access filtering to
SurfPlayerArgumentparsing and to online-name suggestions for both player arguments. - Update publishing workflow to include microservice artifacts/branch and tweak release naming; bump snapshot version.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| surf-core-paper/src/main/kotlin/dev/slne/surf/core/paper/api/access/CorePlayerStatusAccessImpl.kt | Implements the Paper service that evaluates registered access handlers. |
| surf-core-api/surf-core-api-paper/src/main/kotlin/dev/slne/surf/core/api/paper/CorePlayerStatusAccess.kt | Defines the new API and required-service delegation entrypoint. |
| surf-core-api/surf-core-api-paper/src/main/kotlin/dev/slne/surf/core/api/paper/command/argument/SurfPlayerArgument.kt | Filters player argument parsing and suggestions via CorePlayerStatusAccess. |
| surf-core-api/surf-core-api-paper/src/main/kotlin/dev/slne/surf/core/api/paper/command/argument/SurfOfflinePlayerArgument.kt | Filters online-name suggestions via CorePlayerStatusAccess. |
| gradle.properties | Bumps project version to 2.0.1-SNAPSHOT. |
| .github/workflows/publish.yml | Includes microservice artifacts/branch in publishing and adds release title suffix logic. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.