Add getStatsDataPath method for statistical data retrieval#357
Merged
Conversation
…eval - implement getStatsDataPath to return the file system path for storing statistical data - update SurfPaperNmsPlayerBridge and its implementations to include the new method
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new API method for retrieving the path to the player statistics data directory and implements it for both the 1.21.11 and 26.1 NMS bridges. It also bumps the project version to 3.15.0. The changes ensure that the statistics data path can be accessed in a type-safe way across supported Minecraft versions.
API Additions
getStatsDataPath(): Pathto theSurfPaperNmsPlayerBridgeinterface and its API signatures, allowing retrieval of the stats data directory as aPathobject. [1] [2] [3]Implementation Updates
getStatsDataPath()method in bothV1_21_11SurfPaperNmsPlayerBridgeImplandV26_1SurfPaperNmsPlayerBridgeImpl, usingMinecraftServer.getServer().getWorldPath(LevelResource.PLAYER_STATS_DIR)to obtain the correct path. [1] [2]Dependency and Import Maintenance
java.nio.file.Pathand simplify storage-related imports. [1] [2] [3]Versioning
gradle.propertiesto reflect the new API addition.