Merged
Conversation
…nd bump version to 1.21.11-2.74.1
…type syntax in MiniMessageArgument and SuspendCustomArgument
Contributor
There was a problem hiding this comment.
Pull request overview
Updates Surf-API’s CommandAPI integrations to match CommandAPI’s updated argument-type API (supplier/consumer-style), resolving the crash reported in #274.
Changes:
- Bump CommandAPI dependency to
11.2.0. - Update Velocity/Bukkit argument wrappers to pass argument types via method/lambda references instead of eager getters.
- Bump project version to
1.21.11-2.74.0.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| surf-api-velocity/surf-api-velocity-api/src/main/kotlin/dev/slne/surf/surfapi/velocity/api/command/args/SuspendCustomArgument.kt | Switch Argument constructor usage to the new rawType supplier style. |
| surf-api-velocity/surf-api-velocity-api/src/main/kotlin/dev/slne/surf/surfapi/velocity/api/command/args/MiniMessageArgument.kt | Update to StringArgumentType::string supplier reference for the argument type. |
| surf-api-bukkit/surf-api-bukkit-api/src/main/kotlin/dev/slne/surf/surfapi/bukkit/api/command/args/AdventureCompoundBinaryTagArgument.kt | Update to commandArgumentTypes::compoundTag supplier reference; minor formatting. |
| gradle/libs.versions.toml | Bump commandapi version to 11.2.0. |
| gradle.properties | Bump project version to 1.21.11-2.74.0. |
twisti-dev
approved these changes
Apr 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
solves #274