-
Notifications
You must be signed in to change notification settings - Fork 17
feature/Usability and design updates to unsubscribe link setup flow #147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feature/Usability and design updates to unsubscribe link setup flow #147
Conversation
|
@spilzer -- one thing I noticed is that the "Show a Progress Indicator" is not activated by default after installation (I've tried it in 2 different orgs). At minimum, we should probably document this.
All other changes are very good and would be approved, otherwise. PS I did some more research, and it seems like one can set this via the metadata API. Given the additional layer of complexity, it seems like documenting it in setup is the best option. I'll raise it as an issue that we can address in the future. |
@DKeatonDC good catch! I updated the instructions google doc to include steps for activating the progress indicator before running the setup flow. Let me know if what I wrote is sufficient. Thanks! |
DKeatonDC
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving now that documentation has been added.
salgsstyrke
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @spilzer and @DKeatonDC . Unfortunately the progress bar didn't actually advance for me during the flow.

Hrm, I wonder if I somehow didn't update the code in the pull request to use the latest version of the flow. I will try to recreate the error in a fresh dev org since it's currently working in mine. |
|
moving this to draft so we can move ahead with making a new package. |

Critical Changes
Changes
Issues Closed
#93
#105
#113
#114
#144