618 Automate Creation of Public Links for RTAs #629
Conversation
…test class coverage
|
Thanks for the contribution! Before we can merge this, we need @kadp89 to sign the Salesforce Inc. Contributor License Agreement. |
Previous version was overly defensive w.r.t. heap limits. After verifying max field lengths on Summit_Events__c (~13k chars), exotic use of DML in loop is unnecessary and best practices can be followed safely. TODO: review push() for null safety and investigate potential duplication issues in create()
Adds a dedicated handler for the RTF pipeline. Trigger now delegates to handler and passes in the correct trigger context variable. Lays groundwork for future async processing.
Dynamic SOQL was necessary to ensure the full Summit_Events__c object could be introspected and was reinserted. In support, RTF pipeline constructor refactored to accept Trigger.newMap so Ids can be easily extracted and queried. Test class, trigger framework, and minimal handler all updated accordingly. Ready for review.
|
Hello! I submitted this PR a few weeks ago. When you have time, I'd appreciate a review. Happy to iterate as needed. Thanks! |
|
@kadp89 thank you for the work and the PR! At a glance I'm impressed. I especially liked that you added an opt in setting as I was thinking there might be a scenario where SEA users would want to remain in control of public image access and wouldn't want to force this trigger on them. One thing that might be good is to check if the richtext fields are isUpdateable before even acting upon them. This whole process would assume that permission to edit rich text fields has been given in a permission set, if it hasn't we might as well stop the process before it begins. We have been slowly working on getting person account matching active in the next release, so I've been a bit slow in pulling in PR code and testing. Sorry about that. We had a good testing day yesterday and are pretty confident things are working for a release. We may just release to get person account out the door so we can move on to more fun things like this. btw. If you want to be a part of the core group SEA meetings connect with me on trailhead or linked in and let me know. |
|
@tcdahlberg thanks for the review! No worries about the timing -- I'll get to work on the |
2 participants
Critical Changes
None
Changes
SummitEventsRtfLinkPipelineclass to detect<img>tags in rich text fields and replace embeddedContentVersionURLs with correspondingContentDistributionpublic URLs.SummitEventsRtfLinkPipeline_TESTwith passing coverage.SummitEventsTriggerto invoke the pipeline onSummit_Events__cinsert and update.Summit_Events_Settings__cto toggle trigger execution and opt into automation..gitignoreand.forceignoreto remove local development artifacts.Issues Closed
Closes #618