Implement Access levels Page#69
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR implements the Access Levels page redesign: it restyles the tree as a leveled/table-like layout with expand/collapse-all and accessibility attributes, modernizes the edit/rename/upload dialogs to use Material dialog structure, adds access level columns (with show/hide menu action) to the inventory AG Grid, and adjusts supporting types, services, dev proxy, styles, and i18n.
Changes:
- Restyle access-level-tree page with leveled rows, expand/collapse all behavior, and migrate edit/rename/upload dialogs to Material dialog structure (with
seed-dialog-panel). - Add an "Access Level" column group to the inventory grid plus a Hide/Show menu action wired through the actions component.
- Update upload response typing, harden delete 204 handling and dev proxy 204 behavior, extend Material button color rules (incl. dark mode), add access-level cell styles, and add new i18n keys (en/es/fr).
Reviewed changes
Copilot reviewed 20 out of 20 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/styles/styles.scss | Adds .access-level-header/cell styles and dark-mode Material primary/warn button overrides |
| src/app/modules/organizations/access-level-tree/access-level-tree.component.ts | Adds expand-all/collapse-all state and filter expand state save/restore |
| src/app/modules/organizations/access-level-tree/access-level-tree.component.html | Restyles the tree to a leveled table layout with a11y attributes and root header bar |
| .../edit-access-levels-dialog/* | Migrates edit dialog to Material dialog structure; uses seed-alert for warnings |
| .../rename-instance-dialog/* | Pre-fills form control with current name; modernizes layout |
| .../upload-instances-dialog/* | Adopts Material dialog layout; tightens upload response type handling |
| src/app/modules/inventory-list/list/inventory.component.ts/.html | Streams access level names from org and forwards toggle to grid |
| src/app/modules/inventory-list/list/grid/grid.component.ts | Inserts Access Level column group; adds toggle to show/hide ALI columns |
| src/app/modules/inventory-list/list/grid/actions.component.ts/.html | Replaces stubbed Hide with toggle emitting to parent; adds (unused) accessLevelNames input |
| src/@seed/api/organization/organization.types.ts | Loosens UploadAccessLevelInstancesResponse (success/tempfile?/message?) |
| src/@seed/api/organization/organization.service.ts | Treats 0/204 errors from delete as success and refreshes tree |
| proxy.conf.mjs | Strips content-type on 204 to avoid parser crashes |
| public/i18n/{en_US,es,fr_CA}.json | Adds translation keys for new UI strings |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| imports: [MenuItemComponent, MaterialImports], | ||
| }) | ||
| export class ActionsComponent implements OnDestroy, OnChanges, OnInit { | ||
| @Input() accessLevelNames: string[] = [] |
… into access-levels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.