forked from LDAR-Sim/LDAR_Sim
-
Notifications
You must be signed in to change notification settings - Fork 0
Subtype #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
SEAJang
wants to merge
451
commits into
master
Choose a base branch
from
subtype
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Passed all the tests, but not finalized yet
1) Created base company and crew classes 2) Created test classes for Aircraft (test) and for ogi (ogi_test) 3) Updated time offsite parameter to be t_bw_sites, which is settable in method within project files. 4) small formatting chagnes and fixes.
aircraftS_crew.py since agent-scheduling is added to the crew base method
Scheduling has been added to base methods.
1) added switches to disable reading homebases and home base functionality. 2) Moved home base code into base classes from aircraftC method module 3) Added scikit to python requirements 4) Small formatting changes
1) added versions to scipy, yaml, and scikit-learn and numpy. Tested and verified with conda. 2) removed ldar_sim test function call in ldar_sim_main 3) fixed variable name spelling in scheduling
Descriptions are added to get_distance(), find_homebase(), and find_homebase_opt() functions. The distance calculation is switched to Haversine.
Changed Euclidean to Haversine
1) Added intermediate classes which allow customizing based on Alt-technology type using Travel, Fixed, and orbit ideas. 2) Edited variable names, and fixed some spelling errors 3) updated P_test to P_dev_aircraft. 4) fixed some various bugs
Add input parameters explanation for scheduling.
All changes are based on PR LDAR-Sim#67 see for more details
1) Split method name into two variables, a) Label,
which allows users to set an independent name
of the method for graphing or for multiple
of the same method modules within a program.
b) Module, This calls the functionality of the
method module.
2) Reorganized group input parameter data.
3) Updated modules / ldar_sim to make changes
work correctly.
4) Small bug fixes.
1) Added new sensor input parameter. 2) Added submodule into methods module for sensors 3) Moved detect_emission functions into module 4) Moved Scheduling out of Intermediate classes and into base class / deployment folder
1) Created Crew schedule class 2) Made some changes to variables within scheduling 3) Moved rollover logic out of main work a day method into check_time method.
1) Added , end day functions. 2) Fixed bugs.
1) Leaks now include attribution and init detect date. Where leaks at sites itentified by screening are attributed to screening. 2) Added update tag, and update flag functions.
Added Leak Attributions to leaks
!) Set leak facility ID to be a string
Added campaigns
Added campaigns
1) Error occurs when a different number of campaigns occurs. THis will have to be resolved in the future.
1) Added opening message 2) Removed reference to make_map variable
Default input params
1) Also removed the Campaign functions. Will implement manually later.
New changes to optimize the economics module
Added Method Parameter table data
1) Also updated OGI MDL to 7 scfh to match zimmerle.
Modified programs to be dicts instead of lists
1) Renamed OGI camera to ogi camera rk 2) Updated markdown documentation with new sensor
default program parameter now has subtype_file subtype_leak_dist_file is now depricated, values should be entered in the subtype_file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.