Open
Conversation
The tool module and the dummy un-versioned module are removed, as well as the tests. Support code from the test framework and the import test is also removed. Signed-off-by: Mats Wichmann <mats@linux.com>
Oops, the first edit of test/import.py for qt removal worked, but somehow got lost; when I redid it from memory I deleted too much. This puts back the assignment to error_output. Signed-off-by: Mats Wichmann <mats@linux.com>
Collaborator
Author
|
This CI run is seeing the same problem as in #4938 which is presumably a mismatch between the new appveyor setup and the actual provisionong. Or something. This is for: Image: Visual Studio 2017; Environment: WINPYTHON=Python312
I'm presuming that there's a 3.12, but it's not at that path? (It is indeed not part of Appveyor's own base - the VS 2017 image is on Windows Server 2016, which stops at Python 3.8. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Qt3 has been deprecated since SCons 4.3. The tool module and the dummy un-versioned module are removed, as well as the tests. Support code from the test framework and the import test is also removed.
Note there are references to qt in documentation and tests, but used strings in examples (and tests), rather than as a reference to the tool itself, so those were not edited.
Contributor Checklist:
CHANGES.txtandRELEASE.txt(and read theREADME.rst).