Remove fuzz from Point Search, Return Face ID alongside Element ID#308
Draft
matthew-mccall wants to merge 7 commits intoSCOREC:developfrom
Draft
Remove fuzz from Point Search, Return Face ID alongside Element ID#308matthew-mccall wants to merge 7 commits intoSCOREC:developfrom
fuzz from Point Search, Return Face ID alongside Element ID#308matthew-mccall wants to merge 7 commits intoSCOREC:developfrom
Conversation
…related call sites for simplification.
…nding tests for triangle edge distance calculation.
…n and corresponding `construct_intersection_map` overloads for simplification. Refactor related grid search logic and adjust formatting for consistency. Replace `is_barycentric_inside_with_tolerance` with `Omega_h::is_barycentric_inside` in point search logic for simplified tolerance handling. Remove unused function implementation. Replace `element_id` with `face_id` across point search logic for improved entity identification consistency. Refactor tolerance checks and neighbor-cell fallback in `GridPointSearch2D`. Update related tests and adapt internal structures. Add compatibility mode to `GridPointSearch2D` for callers expecting face-based IDs. Update edge classification logic with min/max tracking and refine distance-based hierarchy. Add inflation radius to grid cell bounding boxes in 2D/3D intersection map construction for tolerance handling. Refactor candidate filtering logic in `GridPointSearch2D`. Add overloads for backward compatibility.
# Conflicts: # src/pcms/localization/point_search.cpp # src/pcms/transfer/adj_search.cpp
…x_verts_within_simplex` to replace it. Eliminate `fuzz` parameter in 2D intersection logic for simplification.
…ine splits in `distance_from_line` implementation.
…pter2.h` for consistent line splitting.
Collaborator
|
Offiline discussion: this is generally moving in the right direction. However, we need to update downstream code to work with dim/id data instead of the element id. To do this we should add a function that computes the "owning" element based on the dim/id information. @Angelyr can you point us to the function that you wrote to compute the "owner" from the dim/id? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the mesh field adapters and point search logic to consistently use
face_idxinstead ofelem_idxfor identifying mesh elements, and removes the use of thefuzzparameter from 2D triangle-bounding box intersection logic. The changes improve clarity and correctness in how mesh faces are referenced and streamline the intersection checking code.Mesh element indexing consistency:
mesh_fields_adapter.handmesh_fields_adapter2.hto useface_idxinstead ofelem_idxwhen referencing mesh faces, ensuring consistent and correct indexing throughout the codebase. [1] [2] [3] [4] [5] [6]Point search and intersection logic simplification:
fuzzparameter from the triangle-bounding box intersection logic, refactored thebbox_verts_within_trianglefunction into a more generalbbox_verts_within_simplex, and updated all related calls and functors accordingly. This simplifies the logic and reduces unnecessary parameters. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10]Other improvements:
<cmath>include inpoint_search.cppto ensure mathematical functions are available.