added input to update sign #10
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added an input to update the sign
adarshm11
reviewed
Dec 25, 2025
static/index.html
Outdated
| /> | ||
| <div style="max-width: 700px; margin: 40px auto; text-align: center;"> | ||
| <div style="text-align: left; font-size: 1.5em; margin-bottom: 8px; color: #23292c;">Preview</div> | ||
| <div id="sign-preview" style="background: #eae6de; color: #23302c; border: 6px solid #d32f2f; border-radius: 14px; font-size: 3em; font-family: 'Arial Rounded MT Bold', Arial, sans-serif; font-weight: bold; text-align: center; padding: 20px 0; margin: 0 auto 32px auto; box-sizing: border-box; width: 100%; box-shadow: 0 2px 8px #d32f2f33;"> </div> |
There was a problem hiding this comment.
can we check if all of these classes are required, if not let's try to remove whatever is not necessary
Author
There was a problem hiding this comment.
i checked and removed some unnecessary parts
add input for expiration date and time to update sign
impletemented a try except block to catch errors from running sign binary
using .lstrip to handle cases where the color might not start with #
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added an input to update the sign from status page
