Skip to content

20240719 improve delete api #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jask1m wants to merge 4 commits into
base: dev
Choose a base branch
from
Open

20240719 improve delete api #46

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c019cf2
cleezy
jask1m Jul 13, 2024
b3f9725
improve error handling in deletion
jask1m Jul 20, 2024
af19d6f
reformat logic
jask1m Jul 21, 2024
fb9f8b3
delete accidental folder
jask1m Jul 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 13 additions & 7 deletions server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,17 +131,23 @@ async def get_url(alias: str):
alias_queue.put(alias)
return RedirectResponse(url_output)


@app.post("/delete/{alias}")
async def delete_url(alias: str):
logging.debug(f"/delete called with alias: {alias}")
with MetricsHandler.query_time.labels("delete").time():
if sqlite_helpers.delete_url(DATABASE_FILE, alias):
qr_code_cache.delete(alias)
cache.delete(alias)
return {"message": "URL deleted successfully"}
else:
try:
with MetricsHandler.query_time.labels("delete").time():
if sqlite_helpers.delete_url(DATABASE_FILE, alias):
try: # URL deleted, now attempt the associated data
qr_code_cache.delete(alias)
cache.delete(alias)
except Exception:
logging.exception(f"Error deleting alias {alias} from cache") # log failure without raising exception
Comment on lines +140 to +144
Copy link
Contributor

@evanugarte evanugarte Jul 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can do the nested try for now, and watch the logs to see what happens


return {"message": "URL deleted successfully"}
raise HTTPException(status_code=HttpResponse.NOT_FOUND.code)
except Exception:
logging.error(f"Unexpected error in delete_url for {alias}")
raise HTTPException(status_code=HttpResponse.INTERNAL_SERVER_ERROR.code)

@app.get("/qr/{alias}")
async def qr(alias: str):
Expand Down