-
Notifications
You must be signed in to change notification settings - Fork 2
printing status #140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
printing status #140
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evanugarte
reviewed
Oct 4, 2025
printer/modules/gerard.py
Outdated
| ) | ||
|
|
||
| if is_development_mode: | ||
| if is_development_mode and not is_dev_printer: |
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we merge these variables into one?
development mode = printer is dev too
evanugarte
approved these changes
Dec 22, 2025
evanugarte
added a commit
that referenced
this pull request
Dec 24, 2025
* add dev printer flag; add hold to virtual prints * error checking for status; some other misc changes * remove dev printer flag * fix tests * new completion marking stuff * SILENCE * no more >>> * SLEEP_TIME * remove no_dev_printer --------- Co-authored-by: thebeninator <xccr123@gmail.com>
evanugarte
added a commit
that referenced
this pull request
Dec 24, 2025
* add dev printer flag; add hold to virtual prints * error checking for status; some other misc changes * remove dev printer flag * fix tests * new completion marking stuff * SILENCE * no more >>> * SLEEP_TIME * remove no_dev_printer --------- Co-authored-by: thebeninator <xccr123@gmail.com>
evanugarte
added a commit
that referenced
this pull request
Dec 24, 2025
* add dev printer flag; add hold to virtual prints * error checking for status; some other misc changes * remove dev printer flag * fix tests * new completion marking stuff * SILENCE * no more >>> * SLEEP_TIME * remove no_dev_printer --------- Co-authored-by: thebeninator <xccr123@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
creates a status endpoint for clark