Skip to content

Conversation

@PetrilloAtWork
Copy link
Member

This is part of the pull request SBNSoftware/sbncode#497.
All discussion goes there.

@kjplows
Copy link
Contributor

kjplows commented Mar 26, 2025

Hi @PetrilloAtWork , there are conflicts now - could you please check the change in dep from lardataalg to lardataobj is OK? Thanks!
Pinging @absolution1 and @SFBayLaser here too for review.

@PetrilloAtWork
Copy link
Member Author

PetrilloAtWork commented Apr 3, 2025

The change is the other way, from lardataobj to lardataalg.
This is not a new requirement from this PR, but rather it's a dependency that was overlooked in the past (probably still my fault, but it's a me of several years ago so I repudiate him).

I can rebase to the latest develop, with the hope that it won't be needed again later (hint: it likely will).
[edit] now it is not a good time to rebase, since icaruscode and sbncode develop branches are out of sync. I'll do when they get on the same page again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependent An issue or PR depending on another enhancement New feature or request

Projects

Status: Open pull requests

Development

Successfully merging this pull request may close these issues.

2 participants