Skip to content

Update Pandora track and shower discrimination scheme and training #840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rtriozzi wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Update Pandora track and shower discrimination scheme and training #840

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
164c784
changed Pandora XML to accomodate for track/shower changes
rtriozzi Jul 2, 2025
8f917f8
changed tool name according to PandoraPFA/LArContent changes, updated…
rtriozzi Jul 22, 2025
44452ed
updated CAFMaker configuration to handle BDT tool names
rtriozzi Jul 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions fcl/caf/cafmaker_defs.fcl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -334,6 +334,11 @@ cafmaker.SystWeightLabels: ["genieweight", "fluxweight"]
cafmaker.SaveGENIEEventRecord: true # save GENIE event record by default. Turn this off for data cafmaker fcl
cafmaker.TPCPMTBarycenterMatchLabel: "tpcpmtbarycentermatch"
cafmaker.TrackHitFillRREndCut: 30 # include entire PID region
cafmaker.PFOCharLabels.EndFractionName: "LArThreeDChargeFeatureTool_ICARUS_EndFraction" # override with some ICARUS-specific tool names
cafmaker.PFOCharLabels.FractionalSpreadName: "LArThreeDChargeFeatureTool_ICARUS_FractionalSpread"
cafmaker.PFOCharLabels.HaloTotalRatioName: "LArConeChargeFeatureTool_ICARUS_HaloTotalRatio"
cafmaker.PFOCharLabels.ConcentrationName: "LArConeChargeFeatureTool_ICARUS_Concentration"
cafmaker.PFOCharLabels.ConicalnessName: "LArConeChargeFeatureTool_ICARUS_Conicalness"

# Add CAFMaker to the list of producers
caf_preprocess_producers.cafmaker: @local::cafmaker
Expand Down
17 changes: 11 additions & 6 deletions icaruscode/TPC/Tracking/ICARUSPandora/scripts/PandoraSettings_Neutrino_ICARUS.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -331,17 +331,22 @@
<ShowerPfoListName>ShowerParticles3D</ShowerPfoListName>
<UseThreeDInformation>true</UseThreeDInformation>
<PersistFeatures>true</PersistFeatures>
<MvaFileName>PandoraBdt_v09_72_01_ICARUS_pfochar_bnb.xml</MvaFileName>
<MvaName>PfoCharBDT</MvaName>
<MvaFileNameNoChargeInfo>PandoraBdt_v09_72_01_ICARUS_pfochar_bnb.xml</MvaFileNameNoChargeInfo>
<MvaNameNoChargeInfo>PfoCharBDTNoChargeInfo</MvaNameNoChargeInfo>
<UseICARUSCollectionPlane>true</UseICARUSCollectionPlane>
<MvaFileName>PFOCharBDT_v09_84_00_03_20250718_ICARUSCollection.xml</MvaFileName>
<MvaName>PFOCharBDT_v09_84_00_03_20250718_ICARUSCollection</MvaName>
<MvaFileNameNoChargeInfo>PFOCharBDT_v09_84_00_03_20250718_NoCharge.xml</MvaFileNameNoChargeInfo>
Copy link
Contributor

@brucehoward-physics brucehoward-physics Aug 1, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious - why are these in a separate file instead of putting both into one file as before? (wondering if just a choice or if there is a particular reason e.g.)

Also: checking, in the doc-db presentation you've given with the training results, were they prepared with these changes, so in some way this is already validated?

Copy link
Author

@rtriozzi rtriozzi Aug 12, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The two BDTs (with charge information and without it) came from two separate trainings, so I saved them into two separate XMLs. If you think it would be nicer to have them within a single XML, I can merge them! Thanks Bruce!

Copy link
Contributor

@brucehoward-physics brucehoward-physics Aug 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's probably fine either way.

<MvaNameNoChargeInfo>PFOCharBDT_v09_84_00_03_20250718_NoCharge</MvaNameNoChargeInfo>
<FeatureTools>
<tool type = "LArThreeDLinearFitFeatureTool"/>
<tool type = "LArThreeDVertexDistanceFeatureTool"/>
<tool type = "LArThreeDPCAFeatureTool"/>
<tool type = "LArThreeDOpeningAngleFeatureTool"/>
<tool type = "LArThreeDChargeFeatureTool"/>
<tool type = "LArConeChargeFeatureTool"/>
<tool type = "LArThreeDChargeFeatureTool_ICARUS">
<UseICARUSCollectionPlane>true</UseICARUSCollectionPlane>
</tool>
<tool type = "LArConeChargeFeatureTool_ICARUS">
<UseICARUSCollectionPlane>true</UseICARUSCollectionPlane>
</tool>
</FeatureTools>
<FeatureToolsNoChargeInfo>
<tool type = "LArThreeDLinearFitFeatureTool"/>
Expand Down