Open
Conversation
Member
|
Are you sure there is full coverage info here? |
bd82
approved these changes
Mar 18, 2026
Member
bd82
left a comment
bd82
left a comment
There was a problem hiding this comment.
Look good.
Please verify the coverage info exists.
Its possible with the VSCode Testing Library that coverage is not (easily?) exported
due to running in a separate process.
bd82
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The xml-toolkit subpackage tests were failing in CI with 0% coverage and no useful error message.
Three things were broken:
vscode-testis deprecated and couldn't launch VS Code in a headless CI environment. Switched to@vscode/test-electronand added--headless --disable-gpu --no-sandboxflags.@types/nodethat TypeScript 4.1.3 can't parse. Bumped TypeScript to^5.0.0.mocha.useColors()no longer exists in Mocha 10. Replaced it withcolor: truein the constructor.