feat(builder): Add annotation changes in the flexibilityBundle#1206
Open
Lonwyr wants to merge 1 commit into
Open
feat(builder): Add annotation changes in the flexibilityBundle#1206Lonwyr wants to merge 1 commit into
Lonwyr wants to merge 1 commit into
Conversation
To reflect annotation changes on oData models within the development, these changes must be part of the flexibility bundle to be applied at runtime.
Member
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
codeworrior
reviewed
May 6, 2026
| log.verbose("Collecting flexibility changes"); | ||
| const allResources = await workspace.byGlob( | ||
| `${pathPrefix}/changes/*.{change,variant,ctrl_variant,ctrl_variant_change,ctrl_variant_management_change}`); | ||
| `${pathPrefix}/changes/*.{annotation_change,change,variant,ctrl_variant, |
Member
There was a problem hiding this comment.
double comma required? Can glob handle (ignore) the whitespace?
codeworrior
reviewed
May 6, 2026
| throw new Error( | ||
| "There are some control variant changes in the changes folder. This only works with a " + | ||
| "minUI5Version 1.73.0. Please update the minUI5Version in the manifest.json to 1.73.0 or higher"); | ||
| "There are some files in the changes folder working only with a ui5 version 1.73 and above. " + |
Member
There was a problem hiding this comment.
wording:
- "files" or rather "change file" or "changes"
- "working" or rather "supported"?
- "ui5" has to be spelled "UI5"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To reflect annotation changes on oData models within the development, these changes must be part of the flexibility bundle to be applied at runtime.
SNOW: DINC0862595