Skip to content

fix: precision for long dates #279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
johannes-vogel wants to merge 1 commit into from
Closed

fix: precision for long dates #279

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/protocol/Writer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -861,7 +861,7 @@ Writer.prototype[TypeCode.LONGDATE] = function writeLongDate(value) {
hours = ~~ts[4];
minutes = ~~ts[5];
seconds = ~~ts[6];
nanoseconds = ~~((ts[6] * 1000000000) % 1000000000);
nanoseconds = ~~((ts[6] * 10000000) % 10000000);
Copy link
Contributor Author

@johannes-vogel johannes-vogel Jul 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alternatively, one could split ts[6] by the dot and convert the parts to a number or even adapt the timestamp regexp.

} else {
throw createInputError('LONGDATE');
}
Expand All @@ -877,7 +877,7 @@ Writer.prototype[TypeCode.LONGDATE] = function writeLongDate(value) {
}
const dayDate = calendar.DAYDATE(year, month, day);
const dayFactor = BigInt(10000000) * BigInt(60 * 60 * 24);
const timeValue = BigInt(((hours * 60) + minutes) * 60 + seconds) * BigInt(10000000) + BigInt(~~(nanoseconds / 100));
const timeValue = BigInt(((hours * 60) + minutes) * 60 + seconds) * BigInt(10000000) + BigInt(nanoseconds);
const longDate = BigInt(dayDate - 1) * dayFactor + timeValue + BigInt(1);
var buffer = new Buffer(9);
buffer[0] = TypeCode.LONGDATE;
Expand Down