Demonstrate Hierarchy Functions by etimr · Pull Request #416 · SAP-samples/cloud-cap-samples-java

etimr · 2024-12-18T08:47:05Z

Provides an example of an hierarchy function as ListReport and ValueHelp

currently only READ
to enable tree tables as ListReport add to manifest.json:

"tableSettings": {
     "type": "TreeTable",
     "hierarchyQualifier": "NodesHierarchy",
   ...
}

to enable tree table for ValueHelp hierarchical entity should be annotated with PresentationVariant and root entity with PresentationVariantQualifier

Provides an example of an hierarchy function as `ListReport` and `ValueHelp` - currently only READ - only on HANA Changes: - `LineItem parent.name` is removed from `app/common.cds`, because it leads to OData requests with `$expand` for an hierarchy function which are not supported yet - `sap.common.CodeList` aspect was removed from `Genres` entity because it provides `ValueHelp` dialog implicitly through annotation [@cds.odata.valuelist](https://pages.github.tools.sap/cap/docs/advanced/fiori#convenience-option-cds-odata-valuelist). It also uses the annotation `@cds.autoexpose`, because of this entity `Genres` should be exposed explicitly in `CatalogService` and `ReviewService` after `sap.common.CodeList` is removed. - renaming in the view `GenreHierarchy` is temporal and will be solved by CAP Java team in the future ``` node as node_id, parent_node as parent_id ``` - to [enable tree tables](https://ui5.sap.com//#/topic/7cf7a31fd1ee490ab816ecd941bd2f1f) as `ListReport` add to `manifest.json`: ``` "tableSettings": { "type": "TreeTable", "hierarchyQualifier": "NodesHierarchy", ... } ``` - to enable tree table for ValueHelp hierarchical entity should be annotated with `PresentationVariant` and root entity with `PresentationVariantQualifier` --------- Co-authored-by: D070615 <olena.timrova@sap.com>

Co-authored-by: D070615 <olena.timrova@sap.com>

…name

Support of ExpandLevels in custom code --------- Co-authored-by: D070615 <olena.timrova@sap.com>

…name

…ble-test

Co-authored-by: D070615 <olena.timrova@sap.com>

Co-authored-by: D070615 <olena.timrova@sap.com> Co-authored-by: Evgeny Andreev <evgeny.andreev@sap.com> Co-authored-by: Adrian Görler <adrian.goerler@sap.com> Co-authored-by: Evgeny Andreev <eugene.andreev@gmail.com>

cla-assistant · 2024-12-18T08:47:22Z

All committers have signed the CLA.

cla-assistant · 2024-12-18T08:47:30Z

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
3 out of 4 committers have signed the CLA.

✅ etimr
✅ agoerler
✅ eugene-andreev
❌ OlenaTi
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

db/books.cds

srv/admin-service.cds

srv/review-service.cds

srv/src/main/java/my/bookshop/handlers/HierarchyHandler.java

srv/src/main/resources/application.yaml

srv/admin-service.cds

pom.xml

beckermarc · 2024-12-19T09:41:37Z

db/books.cds

 /**
 * Hierarchically organized Code List for Genres
 */
-entity Genres : sap.common.CodeList {


Why can't you use CodeList from sap.common?

@OlenaTi - do you recall why we changed this?

-> https://github.com/SAP-samples/cloud-cap-samples-java/pull/419/files#diff-d92b8eb29957a03ad9d23b01feff79da293e30183d0b8eac5d893d95632e30dfR51

short version: because it provides a standart ValueHelp dialog and doesn't allow to customize it for Tree Tables,
a little bit more explained: #388 (comment)

beckermarc · 2024-12-19T09:46:29Z

README.md


+### Testing in hybrid mode
+
+You can test the `GenreHierarchyTest` on H2 using the profile `default` as well as on HANA using the profile `hybrid`


I'd rather recommend usage of existing profiles in application.yaml, e.g. cloud, which expects HANA.

etimr and others added 28 commits November 13, 2024 17:25

Fix: ValueHelp Dialog (#397)

cb392f7

Co-authored-by: D070615 <olena.timrova@sap.com>

Fix value help (#398)

2d8f6f8

Co-authored-by: D070615 <olena.timrova@sap.com>

Update fiori-service.cds

1a037e3

UI: Hide ID in ValueHelp (#399)

357611e

Co-authored-by: D070615 <olena.timrova@sap.com>

Update to 3.5.0 & avoid parent_id/node_id projection

7b6179e

Demonstrate custom logic for Tree Tables (#393)

c7f50a8

Merge remote-tracking branch 'origin/feature-tree-table' into avoidRe…

2897b41

…name

Support of ExpandLevels (#403)

45e6b03

Support of ExpandLevels in custom code --------- Co-authored-by: D070615 <olena.timrova@sap.com>

cleanup

7bf5397

Merge remote-tracking branch 'origin/feature-tree-table' into avoidRe…

4b5892d

…name

No projection (#401)

cd01357

fix sorter

3cd209a

Merge remote-tracking branch 'origin/feature-tree-table' into avoidRe…

a8ea2f2

…name

added tests for GenreHierarchy

7e2153e

test in hybrid mode

ae813c2

Test: added tests for GenreHierarchy (#404)

b8d8285

update test

3902076

Merge remote-tracking branch 'origin/feature-tree-table' into tree-ta…

9fe4f93

…ble-test

Merge remote-tracking branch 'origin/main' into feature-tree-table

3a19bc0

parnt -> parent

903852e

Merge remote-tracking branch 'origin/main' into feature-tree-table

a6078cd

fix annotation

17354c9

Added Tree Tables to Readme (#414)

ee8b025

Co-authored-by: D070615 <olena.timrova@sap.com>

Test: added additional tests for GenreHierarchy (#413)

81bd62e

Co-authored-by: D070615 <olena.timrova@sap.com> Co-authored-by: Evgeny Andreev <evgeny.andreev@sap.com> Co-authored-by: Adrian Görler <adrian.goerler@sap.com> Co-authored-by: Evgeny Andreev <eugene.andreev@gmail.com>

fix import

a9db367

more genres (#412)

333d2da

update to 3.6.0-m2451

b7953a0

etimr requested review from agoerler and eugene-andreev December 18, 2024 08:47

remove DEBUG

1c85e8a

agoerler requested changes Dec 18, 2024

View reviewed changes

eugene-andreev reviewed Dec 18, 2024

View reviewed changes

pom.xml Outdated Show resolved Hide resolved

eugene-andreev and others added 4 commits December 18, 2024 13:34

3.6.0

8fd4aad

formatting

0e45154

Merge branch 'main' into feature-tree-table

88c34df

add disclaimer

c127115

agoerler approved these changes Dec 19, 2024

View reviewed changes

agoerler merged commit bde2090 into main Dec 19, 2024
1 check passed

agoerler deleted the feature-tree-table branch December 19, 2024 09:39

beckermarc reviewed Dec 19, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Demonstrate Hierarchy Functions#416

Demonstrate Hierarchy Functions#416
agoerler merged 33 commits intomainfrom
feature-tree-table

etimr commented Dec 18, 2024

Uh oh!

cla-assistant bot commented Dec 18, 2024 •

edited

Loading

Uh oh!

cla-assistant bot commented Dec 18, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

beckermarc Dec 19, 2024

Uh oh!

agoerler Dec 19, 2024

Uh oh!

agoerler Dec 19, 2024

Uh oh!

etimr Dec 19, 2024 •

edited

Loading

Uh oh!

beckermarc Dec 19, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants


		### Testing in hybrid mode

		You can test the `GenreHierarchyTest` on H2 using the profile `default` as well as on HANA using the profile `hybrid`

Conversation

etimr commented Dec 18, 2024

Uh oh!

cla-assistant bot commented Dec 18, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cla-assistant bot commented Dec 18, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

beckermarc Dec 19, 2024

Choose a reason for hiding this comment

Uh oh!

agoerler Dec 19, 2024

Choose a reason for hiding this comment

Uh oh!

agoerler Dec 19, 2024

Choose a reason for hiding this comment

Uh oh!

etimr Dec 19, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

beckermarc Dec 19, 2024

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

cla-assistant bot commented Dec 18, 2024 •

edited

Loading

etimr Dec 19, 2024 •

edited

Loading