cmov: signed integer support #1280
Merged
+106
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds impls of `Cmov`/`CmovEq` for `i8`, `i16`, `i32`, `i164`, and `i128`
Merged
tarcieri
added a commit
that referenced
this pull request
Dec 27, 2025
### Added - Signed integer support (#1280)
tarcieri
added a commit
that referenced
this pull request
Dec 27, 2025
Uses the `Cmov`/`CmovEq` impls added to signed integers (e.g. `i8`, `i16) in #1280 to simplify the macros for writing impls of `CtEq` and `CtSelect` which are backed by the afforementioned `Cmov*` traits. This also allows all of the optimization work to happen in the `cmov` crate.
tarcieri
added a commit
that referenced
this pull request
Dec 27, 2025
Uses the `Cmov`/`CmovEq` impls added to signed integers (e.g. `i8`, `i16`) in #1280 to simplify the macros for writing impls of `CtEq` and `CtSelect` which are backed by the afforementioned `Cmov*` traits. This also allows all of the optimization work to happen in the `cmov` crate.
tarcieri
added a commit
that referenced
this pull request
Dec 27, 2025
Uses the `Cmov`/`CmovEq` impls added to signed integers (e.g. `i8`, `i16`) in #1280 to simplify the macros for writing impls of `CtEq` and `CtSelect` which are backed by the afforementioned `Cmov*` traits. This also allows all of the optimization work to happen in the `cmov` crate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds impls of
Cmov/CmovEqfori8,i16,i32,i164, andi128