ctutils: add u128 methods to Choice
#1277
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds the methods `crypto-bigint` needs for `WideWord` on 64-bit platforms to `Choice`: - `from_u128_le` - `from_u128_lsb` - `select_u128` It would probably be good if `u128` had full parity with `u32` and `u64`, but this just does what's needed for `crypto-bigint` for now.
Merged
tarcieri
added a commit
that referenced
this pull request
Dec 27, 2025
### Added - Additional methods for `CtOption` (#1274): - `some` - `none` - `into_option_copied` - `filter_by` - `as_inner_unchecked` - `to_inner_unchecked` - `Default` impl for `CtOption` (#1274) - `map!` and `unwrap_or!` macros (#1274) - `u128` methods for `Choice` (#1277): - `from_u128_le` - `from_u128_lsb` - `select_u128`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the methods
crypto-bigintneeds forWideWordon 64-bit platforms toChoice:from_u128_lefrom_u128_lsbselect_u128It would probably be good if
u128had full parity withu32andu64, but this just does what's needed forcrypto-bigintfor now.