Skip to content

elliptic-curve: Consistent PKCS#8 / SEC1 naming in secret_key.rs #2388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tarcieri merged 2 commits into from
Apr 17, 2026
+9 −7
Merged

elliptic-curve: Consistent PKCS#8 / SEC1 naming in secret_key.rs #2388

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2324058
elliptic-curve: Consistent PKCS#8 / SEC1 naming in secret_key.rs
dishmaker Apr 17, 2026
f9f8d0f
cargo fmt secret_key.rs
dishmaker Apr 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 9 additions & 7 deletions elliptic-curve/src/secret_key.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -296,13 +296,13 @@ where
#[cfg(feature = "pem")]
#[derive(Debug, Copy, Clone, PartialEq, Eq)]
pub enum PemParseError {
///Indicates invalid PEM string
/// Indicates invalid PEM string
Pem(pem_rfc7468::Error),
///Indicates invalid pkcs8 EC key
/// Indicates invalid PKCS#8 EC key
Pkcs8(::pkcs8::Error),
///Indicates invalid Sec1 EC key
/// Indicates invalid SEC1 EC key
Sec1(::sec1::Error),
///Unable to recognize document label
/// Unable to recognize document label
UnknownLabel,
}

Expand Down Expand Up @@ -336,8 +336,10 @@ impl fmt::Display for PemParseError {
match self {
Self::Pem(error) => fmt.write_fmt(format_args!("Failed to parse PEM: {error}")),
Self::UnknownLabel => fmt.write_str("Unrecognized key label"),
Self::Pkcs8(error) => fmt.write_fmt(format_args!("Faoled to parse Pkcs8 key: {error}")),
Self::Sec1(error) => fmt.write_fmt(format_args!("Faoled to parse SEC1 key: {error}")),
Self::Pkcs8(error) => {
fmt.write_fmt(format_args!("Failed to parse PKCS#8 key: {error}"))
}
Self::Sec1(error) => fmt.write_fmt(format_args!("Failed to parse SEC1 key: {error}")),
}
}
}
Expand All @@ -355,7 +357,7 @@ where
///
/// Supported formats:
/// - `SEC1` - requires feature `sec1`
/// - `PKCS #8` - requires feature `pkcs8`
/// - `PKCS#8` - requires feature `pkcs8`
///
/// # Errors
/// - If `pem` is not valid PEM encoded private key
Expand Down